Fix CupertinoSliverRefreshControl onRefresh callback#32086
Merged
LongCatIsLooong merged 3 commits intoflutter:masterfrom May 4, 2019
Merged
Fix CupertinoSliverRefreshControl onRefresh callback#32086LongCatIsLooong merged 3 commits intoflutter:masterfrom
LongCatIsLooong merged 3 commits intoflutter:masterfrom
Conversation
5ded4f2 to
1cd76c4
Compare
1cd76c4 to
914dfeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
CupertinoSliverRefreshControl.onRefresh'sthencallback withwhenCompletedcallback, so whenonRefreshcompletes with error the sliver refresh control retracts like when it completes with value.Related Issues
Fixes #31382
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?