Skip to content

Add breadcrumbs to TextOverflow#32328

Merged
goderbauer merged 1 commit intoflutter:masterfrom
esarbanis:add_breadcrumbs_to_text_overflow
May 10, 2019
Merged

Add breadcrumbs to TextOverflow#32328
goderbauer merged 1 commit intoflutter:masterfrom
esarbanis:add_breadcrumbs_to_text_overflow

Conversation

@esarbanis
Copy link
Contributor

Description

Add breadcrumbs to TextOverflow dartdoc

Related Issues

fixes #6910

Tests

I added the following tests:

Not tests are needed

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@goderbauer goderbauer added the framework flutter/packages/flutter repository. See also f: labels. label May 9, 2019
@esarbanis esarbanis force-pushed the add_breadcrumbs_to_text_overflow branch from f91d83a to 55c473d Compare May 9, 2019 17:27
@esarbanis esarbanis force-pushed the add_breadcrumbs_to_text_overflow branch from 55c473d to ab17c8b Compare May 10, 2019 09:08
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer merged commit b24f1f7 into flutter:master May 10, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TextOverflow docs have no breadcrumbs

3 participants