Skip to content

Add ancestor and descendant finders to Driver#32410

Merged
goderbauer merged 7 commits intoflutter:masterfrom
goderbauer:ancestordescendant
May 10, 2019
Merged

Add ancestor and descendant finders to Driver#32410
goderbauer merged 7 commits intoflutter:masterfrom
goderbauer:ancestordescendant

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented May 9, 2019

Description

Adds ancestor and descendant similar to WidgetTester.ancestor and WidgetTester.descendant to Flutter Driver.

Related Issues

#29375

Tests

I added the following tests:

  • Tests for the two new matchers

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@goderbauer
Copy link
Member Author

/cc @adazh @tvolkert

@goderbauer goderbauer added the framework flutter/packages/flutter repository. See also f: labels. label May 9, 2019
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer force-pushed the ancestordescendant branch from 893938b to 6d756fa Compare May 10, 2019 11:35
@goderbauer goderbauer merged commit b37c3be into flutter:master May 10, 2019
@goderbauer goderbauer deleted the ancestordescendant branch May 10, 2019 16:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants