Merged
Conversation
Contributor
Author
|
Some of the updated tests appear to fail on windows/Linux but pass on macOS... |
justinmc
approved these changes
May 10, 2019
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
I saw the same thing when I added some tests like this, where the Mac tests would fail due to being off by slightly too much. I tried to prefer moreOrLessEquals but found that the threshold was too small for the Mac tests. All other tests worked though, including locally, and I couldn't reproduce the Mac failure locally. Not sure what's up.
Anyway, I'm all for standardizing and simplifying error tolerance like this. I'm hoping that the tests pass and you don't have to remove more tests.
LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prefer using
precisionErrorTolerancerather than random hardcoded epsilons when we need an epsilon. Also prefermoreOrLessEquals(which uses precisionErrorTolerance by default) rather thancloseTo.Tests
I added the following tests:
Updated existing tests.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?