Fix transforms for things with RenderPointerListeners#32535
Merged
gspencergoog merged 3 commits intoflutter:masterfrom May 13, 2019
Merged
Fix transforms for things with RenderPointerListeners#32535gspencergoog merged 3 commits intoflutter:masterfrom
gspencergoog merged 3 commits intoflutter:masterfrom
Conversation
Contributor
Author
|
cc @goderbauer |
gspencergoog
force-pushed
the
fix_layer_transforms
branch
from
7e65d62 to
5c16048
Compare
dkwingsmt
reviewed
May 13, 2019
dkwingsmt
approved these changes
May 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes #32525, because it now marks the compositing bits as needing to be recalculated if the mouse tracker changes its idea of whether or not a mouse is attached.
This bug occurred because the test framework was leaking state from one test to the next (the state about whether a mouse pointer was active), and so even though there was a "passing" test when run in order with the other tests in the file, when the test was run individually (or first), it would have failed and caught the bug.
This adds an assert to make sure that after each test there are no simulated mouse pointers connected, and now calls
removePointerin all of the tests where this was a problem.Related Issues
Fixes #32525
Tests
There was no need to add a test: the relevant test already existed, but was not failing in CI because of the non-hermetic test framework.