Skip to content

Updates latest gradle & kotlin versions#32550

Closed
ened wants to merge 7 commits intoflutter:masterfrom
ened:gradle-3.4.0
Closed

Updates latest gradle & kotlin versions#32550
ened wants to merge 7 commits intoflutter:masterfrom
ened:gradle-3.4.0

Conversation

@ened
Copy link
Contributor

@ened ened commented May 11, 2019 •
edited
Loading

Description

Updates all Gradle & Kotlin references to their latest versions.
We have seen significant build performance improvements after upgrading, with the requirement that all components, apps and packages need to stay in sync rgd. the gradle version.

The FlutterLogger class has been deactivated & removed from the build system as it was eating build errors. It didn't have any documentation or other references therefore I believe it was added to circumvent Gradle 4 log issues and thus now removed.

Also, updating the default gradle file templates results in a smoother developer experience: Currently, generating a flutter project results in Android Studio prompting for the gradle update. IMHO Flutter should stay in sync with mainline versions as closely as possible.

Related Issues

Can close #19719 after this is merged, old issue.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@ened
Copy link
Contributor Author

ened commented May 11, 2019

The Windows tests fail for other reasons with the error message:

 * getMinIntrinsicWidth(Infinity) returned a larger value (40.0) than getMaxIntrinsicWidth(Infinity)
(24.0)

@ened ened mentioned this pull request May 11, 2019
Closed
13 tasks
@josh-burton
Copy link
Contributor

josh-burton commented May 11, 2019

Related: #31029

@ened
Copy link
Contributor Author

ened commented May 11, 2019

Argh, didn’t see your PR, @athornz. :-)

Only difference seems a slight version update (5.4.1 vs 5.4, Kotlin 1.3.31) in this PR vs yours.

Will you update yours? If yes we can close this one.

@josh-burton
Copy link
Contributor

josh-burton commented May 11, 2019

Yeah, it's been open for a while! Yours is more up to date and we may as well leave them both open so there's more chance of getting them merged.

@ened
Copy link
Contributor Author

ened commented May 12, 2019

Flaky test was resolved by simply re-running it. This is now passing. @gspencergoog - is this something you could help to approve / merge?

@shihaohong shihaohong added the tool Affects the "flutter" command-line tool. See also t: labels. label May 13, 2019
@collinjackson collinjackson requested a review from dnfield May 14, 2019 00:00
@tvolkert tvolkert requested a review from collinjackson May 15, 2019 15:01
@ened
Copy link
Contributor Author

ened commented May 23, 2019

@blasten perhaps you could help to review this as well.
I noticed that v 1.6.1 from dev does not build my project properly, and the error is eaten by the FlutterLogger, which this PR removes.

@ened ened mentioned this pull request May 23, 2019
Closed
9 tasks
@ened
Copy link
Contributor Author

ened commented May 23, 2019

Not upgrading the gradle version to 3.4.1 in flutter.gradle will create the next set problems when users upgraded their NDK which does not include mipsel64-linux etc.. (a deprecated target platform).

@blasten Could you please take a look here, as well. :-)

@dnfield dnfield requested a review from blasten July 13, 2019 18:03
blasten
blasten suggested changes Jul 18, 2019
View reviewed changes
@blasten blasten mentioned this pull request Jul 18, 2019
Closed
9 tasks
@zanderso zanderso mentioned this pull request Sep 3, 2019
Closed
@blasten blasten mentioned this pull request Sep 10, 2019
Merged
@blasten
Copy link

blasten commented Sep 10, 2019

I will continue the update in #40181 since there are test failures.

@blasten blasten closed this Sep 10, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dnfield dnfield Awaiting requested review from dnfield

@collinjackson collinjackson Awaiting requested review from collinjackson

1 more reviewer

@blasten blasten blasten requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gradle: "Could not resolve com.android.tools.build:gradle:3.1.2."

5 participants

@ened @josh-burton @blasten @googlebot @shihaohong