Skip to content

Add barcode scanner to Shrine example#32646

Closed
bparrishMines wants to merge 57 commits intoflutter:masterfrom
bparrishMines:shrine_barcode
Closed

Add barcode scanner to Shrine example#32646
bparrishMines wants to merge 57 commits intoflutter:masterfrom
bparrishMines:shrine_barcode

Conversation

@bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented May 13, 2019

Description

Add a live barcode scanner to the Shrine example in the flutter_gallery app.

Related Issues

Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR.

Tests

No tests since this is uses camera and firebase_ml_vision. Also, its example code.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@bparrishMines
Add camera page and window frame widget
2054e13
@bparrishMines
bottom bar and app bar
ca41033
@bparrishMines
Setup Barcode scanner for android
f736989
@bparrishMines
Gradient top
1e5a49d
@bparrishMines
Only valid barcode in rect
c662815
@bparrishMines
Take picture of barcode
a307298
@bparrishMines
Show bottom sheet
fe46c55
@bparrishMines
Bottom sheet
e209e47
@bparrishMines
Close page when bottom sheet is closed
9a47913
@bparrishMines
Remove some global variables
5bdce16
@bparrishMines
Formatting
4fc222f
@bparrishMines
Change CameraApp to BarcodeScanner
a1cd1ac
@bparrishMines
Pulsing square
147c3d1
@bparrishMines
Add iOS use
21f4912
@bparrishMines
Fix systemchrome and stop animation on barcode found
2afcebb
@bparrishMines
Finish loading animation
c9ce270
@bparrishMines
Use only one animation
5bdaced
@bparrishMines
Name changes and use only one widget
fc4ef23
@bparrishMines
Add innerframe painting to window painter
9b7f2da
@bparrishMines
Renames and switch to methods
e00bdf4
@bparrishMines
change utils to a class and add strokeWidth param
a81d65c
@bparrishMines
Page rename
ecf08af
@bparrishMines
fix safearea problem
9a04f00
@bparrishMines
Safe area and transform
187fb37
@bparrishMines
Merge remote-tracking branch 'origin/master' into shrine_barcode
31dde3e
@bparrishMines
Merge branch 'master' into shrine_barcode
f1bb1ff
@bparrishMines
Const
d9070e4
@bparrishMines
Add image zoom to fill screen
2975b5a
@bparrishMines
Somewhat better valid rect detection
6a53d0d
@bparrishMines
Frame color and button shape
0c66859
@bparrishMines bparrishMines requested a review from willlarche May 13, 2019 22:18
skreborn
skreborn reviewed May 14, 2019
View reviewed changes
skreborn
skreborn reviewed May 14, 2019
View reviewed changes
examples/flutter_gallery/lib/demo/shrine/backdrop.dart
}) : assert(frontTitle != null),
assert(backTitle != null),
super(key: key, listenable: listenable);
}) : assert(frontTitle != null),
Copy link

@skreborn skreborn May 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the extra padding?

@ghost
Copy link

ghost commented May 16, 2019 •
edited by ghost
Loading

related : #32526
btw i tried your code but there is something wrong with barcode.boundingbox

its x,y are reversed for some reason - android 9 : honor play
so i need to do this to fix the check if the barcode is in valid:

final reversedXY = Rect.fromLTRB( barcode.boundingBox.top, barcode.boundingBox.left, barcode.boundingBox.bottom, barcode.boundingBox.right, ); final Rect intersection = validRect.intersect(reversedXY);

@skreborn
Copy link

skreborn commented May 16, 2019 •
edited
Loading

@KirolousNashaat I believe this might be because the detector is given the camera's current orientation, but I don't see _handleResult accounting for the same. Perhaps your camera is detected as rotated - can you test and see what camera.sensorOrientation is for you.

Then again, I might be completely off here.

@ghost
Copy link

ghost commented May 16, 2019 •
edited by ghost
Loading

@KirolousNashaat I believe this might be because the detector is given the camera's current orientation, but I don't see _handleResult accounting for the same. Perhaps your camera is detected as rotated - can you test and see what camera.sensorOrientation is for you.

Then again, I might be completely off here.

u are right , just tested my orientation is 90 in portrait ?
i think i should rotate the validRect with my sensor orientation , 90 / 270 = treat them the same ?

@ghost
Copy link

ghost commented May 16, 2019 •
edited by bparrishMines
Loading

like this :

if (cameraDescription.sensorOrientation == 90 || cameraDescription.sensorOrientation == 270) {
    validRect = Rect.fromLTRB(
        center.dy - halfHeight,
        center.dx - halfWidth,
        center.dy + halfHeight,
        center.dx + halfWidth,
    );
} else {
    validRect = Rect.fromLTRB(
        center.dx - halfWidth,
        center.dy - halfHeight,
        center.dx + halfWidth,
        center.dy + halfHeight,
    );
}

btw :
_cameraController.stopImageStream(); freezes the app for a moment

@HansMuller HansMuller added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. labels May 16, 2019
@bparrishMines bparrishMines mentioned this pull request May 29, 2019
Closed
9 tasks
@bparrishMines bparrishMines mentioned this pull request Jun 11, 2019
Merged
13 tasks
@bparrishMines bparrishMines mentioned this pull request Jun 18, 2019
Merged
13 tasks
@bparrishMines
Copy link
Contributor Author

bparrishMines commented Jun 19, 2019

This example is now in the flutter/plugins repo with PR flutter/plugins#1758

@bparrishMines bparrishMines deleted the shrine_barcode branch June 19, 2019 22:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@willlarche willlarche Awaiting requested review from willlarche

1 more reviewer

@skreborn skreborn skreborn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bparrishMines @skreborn @HansMuller @googlebot