Text field focus and hover support.#32776
Merged
gspencergoog merged 3 commits intoflutter:masterfrom May 17, 2019
Merged
Conversation
594d043 to
93d71b9
Compare
93d71b9 to
ead9362
Compare
ead9362 to
7e1227a
Compare
7e1227a to
228d3a9
Compare
darrenaustin
approved these changes
May 16, 2019
Contributor
darrenaustin
left a comment
There was a problem hiding this comment.
Other than the extraneous print statement, LGTM.
228d3a9 to
b3c4104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds support for an animated
focusColorandhoverColortoInputDecorator. This color will blend with the background over a fade in period whenever theInputDecoratoris focused or hovered, respectively.It also adds a Listener to the TextField to listen for hover events.
Tests
I added the following tests:
focusColoris drawn and animates when focus changes.hoverColoris drawn and animates when hovering.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?