Yes, this is great! 🚀

Since I have a deployment target of iOS 12 in my main app, my app doesn't build arm 32-bit code, but since some of the pods have a much lower deployment target they do. This leaves me with linking errors when I'm trying to archive the app, and the only fix I've found is to bump the deployment target to 12 on all my pods as well.

This leaves me in a state where I have to manually update the podhelper.rb every time I'm doing a release (since it's an autogenerated file I lose the changes all the time), to let the post-install hook add the updated deployment target...

ref: CocoaPods/CocoaPods#4859 (comment)

cc @jmagman

You had a good solution to adding a method to the podhelper so existing Podfiles don't get clobbered. I took a stab at a larger change that should hopefully solve things in a more complete, more CocoaPods-friendly way, and included the spirit of your change:
#36793
When that lands, you should be able to just update your Podfile targets that need the Flutter symbols, plugins, etc:

load File.join('my_flutter', '.ios', 'Flutter', 'podhelper.rb')
target 'MyApp' do
  install_all_flutter_pods 'my_flutter'
end

There will no longer be any post_install hooks required by Flutter.

@truongsinh I'm hoping your issue is fixed by #36793. You can migrate your Podfile as I suggested above, and try it on the master channel. https://github.com/flutter/flutter/wiki/Flutter-build-release-channels
If it's not resolved, please file an issue and @ me!

A quick try seems that the current master of Flutter assumes FLUTTER_ROOT is set, but it is not necessarily true, nor mentioned in https://github.com/flutter/flutter/wiki/Add-Flutter-to-existing-apps#ios

A quick try seems that the current master of Flutter assumes FLUTTER_ROOT is set, but it is not necessarily true, nor mentioned in https://github.com/flutter/flutter/wiki/Add-Flutter-to-existing-apps#ios

You need to remove the xcode_backend build script phase you previously added to the app. You no longer need it. I was going to write up migration instructions tomorrow but you were too fast!

after removing xcode_backend build scrip and some other small changes, it works 🎉

@truongsinh What were the "other small changes"? I want to make sure I cover everything in the migration instructions.

@truongsinh What were the "other small changes"? I want to make sure I cover everything in the migration instructions.

It might be specific to our app only, but anyway 2 things

1

unrecognized selector applicationDidBecomeActive

our app delegate extends/implements FlutterAppDelegate, FlutterStreamHandler

class AppDelegate: FlutterAppDelegate, FlutterStreamHandler {

down there in this class, we used to override applicationDidBecomeActive and call super.applicationDidBecomeActive, but in this version, calling super will crash the app

    override func applicationDidBecomeActive(_ application: UIApplication) {
        // .. do own own stuff

        // can no longer call supper (used to be able to call in previous Add2App version) because
        // `reason: '-[myApp.AppDelegate applicationDidBecomeActive:]: unrecognized selector sent to instance 0x6000011faf00'`
        // super.applicationDidBecomeActive(application)
        
    }

2

flutterEngine is no longer a binaryMessenger protocol, but need to change to flutterEngine.binaryMessenger

-        eventChannel = FlutterEventChannel.init(name: eventChannelName, binaryMessenger: flutterEngine)
-        methodChannel = FlutterMethodChannel.init(name: methodChannelName, binaryMessenger: flutterEngine)
+        eventChannel = FlutterEventChannel.init(name: eventChannelName, binaryMessenger: flutterEngine.binaryMessenger)
+        methodChannel = FlutterMethodChannel.init(name: methodChannelName, binaryMessenger: flutterEngine.binaryMessenger)