Restructure macOS project files#33608
Merged
stuartmorgan-g merged 1 commit intoflutter:masterfrom May 30, 2019
Merged
Conversation
Rather than macos/Flutter containing a mixture of files that should and shouldn't be checked in, create clear locations for: - Files that are "owned" by Flutter, but should be checked in (Flutter/). This will contain files like the top-level Flutter xcconfigs, generated plugin registrants, etc. - Files that are generated by Flutter on the fly, and should not be checked in (Flutter/ephemeral/). This will contain Flutter SDK caches, the generated xcconfig, etc. Also adds Flutter-owned Debug and Release xcconfig variants, in preparation for PodSpec tooling.
stuartmorgan-g
added a commit
to stuartmorgan-g/flutter-desktop-embedding
that referenced
this pull request
May 30, 2019
Reworks projects for the changes in flutter/flutter#33608 Adds an extra layer of xcconfig indirection, so that there's a clear distinction between the xcconfigs that are entirely human-managed, and the configs that Flutter will manage (which is useful for Pod handling, where Flutter needs to add configuration-specific xcconfig changes).
Piinks
added
the
tool
stuartmorgan-g
added a commit
to google/flutter-desktop-embedding
that referenced
this pull request
May 30, 2019
Reworks projects for the changes in flutter/flutter#33608 Adds an extra layer of xcconfig indirection, so that there's a clear distinction between the xcconfigs that are entirely human-managed, and the configs that Flutter will manage (which is useful for Pod handling, where Flutter needs to add configuration-specific xcconfig changes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rather than macos/Flutter containing a mixture of files that should and
shouldn't be checked in, create clear locations for:
(Flutter/). This will contain files like the top-level Flutter
xcconfigs, generated plugin registrants, etc.
checked in (Flutter/ephemeral/). This will contain Flutter SDK caches,
the generated xcconfig, etc.
Also adds Flutter-owned Debug and Release xcconfig variants, in
preparation for PodSpec tooling.
Related Issues
None.
Tests
I added the following tests: None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?
(This is a breaking change, but only for macOS, which is explicitly unstable.)