Implement plugin tooling support for macOS#33636
Merged
stuartmorgan-g merged 1 commit intoflutter:masterfrom May 31, 2019
Merged
Implement plugin tooling support for macOS#33636stuartmorgan-g merged 1 commit intoflutter:masterfrom
stuartmorgan-g merged 1 commit intoflutter:masterfrom
Conversation
Enables the CocoaPods-based plugin workflow for macOS. This allows a macOS project to automatically fetch and add native plugin implementations via CocoaPods for anything in pubspec.yaml, as is done on iOS.
Piinks
added
e: desktop
tool
stuartmorgan-g
added a commit
to google/flutter-desktop-embedding
that referenced
this pull request
May 31, 2019
First half of updating for flutter/flutter#33636 For example: - Switched from placeholder PluginRegistrant to empty. - GeneratedPluginRegistrant, as with a default iOS project. For testbed: - Same change as to example/ as a starting point. - Removed the direct dependency on example_plugin. - Ran 'flutter run', which created the rest of the changes. For example_plugin: - Removed the Xcode project and framework-related files. - Updated structure and file naming to match iOS plugin format. - Added a podfile. For all other plugins: - Commented out macosPrefix so that the new tooling won't attempt to treat them as pods and fail. The second half will be updating the other plugins to pods; that's left as a follow-up to limit the scope of this patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables the CocoaPods-based plugin workflow for macOS. This allows a
macOS project to automatically fetch and add native plugin
implementations via CocoaPods for anything in pubspec.yaml, as is done
on iOS.
Related Issues
Fixes #32718
Tests
I added the following tests: New test for macOS-specific branch in cocoapods.dart.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?