Add documentation to ImplicitlyAnimatedWidgetState#33674
Merged
tvolkert merged 2 commits intoflutter:masterfrom Jun 1, 2019
tvolkert:docs
Merged
Add documentation to ImplicitlyAnimatedWidgetState#33674tvolkert merged 2 commits intoflutter:masterfrom tvolkert:docs
tvolkert merged 2 commits intoflutter:masterfrom
tvolkert:docs
Conversation
This is a follow-on to #33370 based on review comments therein.
9 tasks
HansMuller
approved these changes
May 31, 2019
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
LGTM
I think the forEachTween doc would also be worth clarifying. It would be good if the doc made it crystal clear, at the outset, that the subclass's override needs to apply the visitor callback to each of its tweens (not "animatable facet" even if that's somehow more correct).
goderbauer
added
the
framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The documentation for
ImplicitlyAnimatedWidgetStatewas ambiguous in a few places. This PR attempts to clarify those docs.This is a follow-on to #33370 based on review comments therein.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?