Skip to content

Fixing duplicate golden test names#33805

Merged
Piinks merged 1 commit intoflutter:masterfrom
Piinks:goldDuplicates
Jun 4, 2019
Merged

Fixing duplicate golden test names#33805
Piinks merged 1 commit intoflutter:masterfrom
Piinks:goldDuplicates

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Jun 3, 2019

Description

This PR modifies the names of 4 golden file tests that were presenting a conflict in #33688 (Skia Gold).
This change incorporates the library into the naming structure to differentiate between two otherwise identical file names.
Golden files have already been updated here.
Obsolete files updated here.

Related Issues

Fixes #33804
Filed #33806 to follow-up on preventing this in the future as Gold gets ready to land

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jun 3, 2019
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks merged commit 04015b9 into flutter:master Jun 4, 2019
@Piinks Piinks deleted the goldDuplicates branch July 9, 2019 17:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate Golden Image Test Names

3 participants