Revert "Prevent exception being thrown on hasScrolledBody"#34061
Merged
Revert "Prevent exception being thrown on hasScrolledBody"#34061
Conversation
This reverts commit ab707ac.
Contributor
Author
dnfield
approved these changes
Jun 7, 2019
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM - do you have the failing test?
Contributor
|
Nevermind I see it on the issue. |
amirh
deleted the
revert-31485-NestedScrollPosition_toDouble_exception_31195
branch
Contributor
|
@amirh Could you please provide a code sample that I could use to reproduce this error? I find it a bit strange that though the PR fixes some of the publicly listed bugs, it gets reverted because of an internal test that is not reproducible in public. Could it be that the reverted PR actually shows a problem in the testing infrastructure, rather than is being a cause of an error? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #31485
Caused a regression that's blocking the roll, see #34003