Added customizable padding for the segmented controll#34555
Merged
LongCatIsLooong merged 1 commit intoflutter:masterfrom Jun 16, 2019
vanlooverenkoen:Feature/25989-cupertino-segmented-controll-horizontal-padding
Merged
Added customizable padding for the segmented controll#34555LongCatIsLooong merged 1 commit intoflutter:masterfrom vanlooverenkoen:Feature/25989-cupertino-segmented-controll-horizontal-padding
LongCatIsLooong merged 1 commit intoflutter:masterfrom
vanlooverenkoen:Feature/25989-cupertino-segmented-controll-horizontal-padding
Conversation
Fixed comments from #30807
LongCatIsLooong
approved these changes
Jun 16, 2019
Contributor
|
Thanks for the PR! |
vanlooverenkoen
deleted the
Feature/25989-cupertino-segmented-controll-horizontal-padding
branch
tango5614
added a commit
to tango5614/flutter
that referenced
this pull request
Jun 17, 2019
* master: retry on HttpException (flutter#34526) 308c113 Roll src/third_party/skia 057a32d9a2c8..5fe7429babe2 (1 commits) (flutter/engine#9342) (flutter#34583) Add back ability to override the local engine in Gradle (flutter#34460) Added customizable padding for the segmented controll (flutter#34555) 466a1d8 Roll src/third_party/skia 3721688f64a5..057a32d9a2c8 (1 commits) (flutter/engine#9340) (flutter#34558) Handles parsing APK manifests with additional namespaces or attributes (flutter#34535) add route information to Flutter.Navigation events (flutter#34508) Separate web and io implementations of network image (flutter#34112) pass .packages path to snapshot invocation (flutter#34517) [Material] Fix TextDirection and selected thumb for RangeSliderThumbShape and RangeSliderValueIndicatorShape (flutter#34501) redux of a change to use new engine APIs for Flutter.Frame events (flutter#34521) Roll engine b0757e6..f44b7b5 (4 commits) (flutter#34533) Roll engine 2589785..b0757e6 (6 commits) (flutter#34522) Revert "Revert "redux of a change to use new engine APIs for Flutter.Frame events (flutter#34365)" (flutter#34514)" (flutter#34530) Make sure fab semantics end up on top (flutter#34512) Revert "redux of a change to use new engine APIs for Flutter.Frame events (flutter#34365)" (flutter#34514) redux of a change to use new engine APIs for Flutter.Frame events (flutter#34365)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a configurable padding for the CupertinoSegmentedControl. The default of 16 will still be used if no padding was set.
#25989
This pull request should fix the issues we had with #30807 @LongCatIsLooong