Skip to content

Re-land config lib dependencies for flavors #34668

Merged
tvolkert merged 9 commits intoflutter:masterfrom
blasten:gradle_flavors
Jun 19, 2019
Merged

Re-land config lib dependencies for flavors #34668
tvolkert merged 9 commits intoflutter:masterfrom
blasten:gradle_flavors

Conversation

@blasten
Copy link

@blasten blasten commented Jun 18, 2019 •
edited
Loading

Description

Re-land #34592 (waiting on #34655)

Related Issues

Fixes: #34651 and #24106

Tests

I added the following tests:

2 unit tests in gradle_plugin_light_apk_test.dart

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@blasten blasten requested review from mklim and tvolkert June 18, 2019 20:44
@blasten blasten added the t: gradle "flutter build" and "flutter run" on Android label Jun 18, 2019
@tvolkert
Copy link
Contributor

tvolkert commented Jun 18, 2019

Does this also fix #24106?

@blasten
Copy link
Author

blasten commented Jun 18, 2019

@tvolkert yep. I just added it to the description.

tvolkert
tvolkert approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mklim
mklim approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert
Copy link
Contributor

tvolkert commented Jun 19, 2019

Merging while the tree's green 🙂

@tvolkert tvolkert merged commit c50fa3d into flutter:master Jun 19, 2019
@blasten blasten deleted the gradle_flavors branch June 19, 2019 17:44
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@johnsonmh
Re-land config lib dependencies for flavors (flutter#34668)
cbcd500
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mklim mklim mklim approved these changes

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

t: gradle "flutter build" and "flutter run" on Android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flutter run with flavor to Android device is broken on master

4 participants

@blasten @tvolkert @mklim @googlebot