Fix FocusTraversalPolicy makes focus lost#34712
Merged
gspencergoog merged 4 commits intoflutter:masterfrom Jul 17, 2019
Merged
Conversation
boyan01
changed the title
Contributor
Author
|
@darrenaustin @gspencergoog Review Request |
goderbauer
added
a: desktop
Contributor
|
The release smoke tests failure is expected. @gspencergoog would really be the best person to review this, but he is OOO right now. Sorry for the delay, but it would be best if we can wait until he's back to review this. |
dnfield
reviewed
Jun 26, 2019
Contributor
Author
thanks for your reply. of course we could wait spencergoog back to review, maybe he has better ideas to fix this issue. |
gspencergoog
reviewed
Jul 9, 2019
gspencergoog
approved these changes
Jul 10, 2019
Co-Authored-By: Greg Spencer <[email protected]>
Co-Authored-By: Greg Spencer <[email protected]>
Contributor
|
Hi @boyan01, Are you ready for this to be merged? It looks like this is ready to go unless you would like to make more changes. |
Contributor
Author
gspencergoog
changed the title
Contributor
|
@boyan01, thanks so much for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FocusTraversalPolicy keep the previously visited node to avoid hysteresis. But even if the visited focus has been disposed, FocusTraversalPolicy will still use it to requestFocus, which will cause FocusManger to get an abandoned node to get the focus.
Related Issues
Fixes #34153
Fixes #33435
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?