add documentation for conic path not supported#35063
Merged
cyanglaz merged 3 commits intoflutter:masterfrom Jul 8, 2019
Merged
add documentation for conic path not supported#35063cyanglaz merged 3 commits intoflutter:masterfrom
cyanglaz merged 3 commits intoflutter:masterfrom
Conversation
Piinks
added
plugin
a: platform-views
goderbauer
added
the
framework
goderbauer
reviewed
Jul 3, 2019
| /// Construction of UIViews is done asynchronously, before the UIView is ready this widget paints | ||
| /// nothing while maintaining the same layout constraints. | ||
| /// | ||
| /// If a conic path clipping is applied to a UIKitView, a quad path is used to approximate the clip due to limitation of Quartz. |
Member
There was a problem hiding this comment.
nit: we try to keep doc comment lines to be ~80 characters long. This one locks longer.
Contributor
Author
There was a problem hiding this comment.
It's definitely longer :), I will edit before merging.
goderbauer
reviewed
Jul 3, 2019
| /// | ||
| /// Construction of UIViews is done asynchronously, before the UIView is ready this widget paints | ||
| /// nothing while maintaining the same layout constraints. | ||
| /// |
Member
There was a problem hiding this comment.
looks like there's a whitespace at the end of this line that makes cirrus mad. :)
Contributor
Author
There was a problem hiding this comment.
Good catch! Thanks. VSCode always generates /// with an empty space in the end when hit return key on the keyboard after a line of dart doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding document to explain that iOS platform view clipping is not fully supported for conic path.
Related Issues
#35062
Tests
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?