We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@miguelpruivo thank you for the pull request and the issue! However tests are required for a PR to be able to get merged.

After testing on an iOS 12 device, it appears to me that the system text scale settings only apply to the "content" area (i.e. what we refer to in flutter as Scaffold.body). Neither tab navigation nor top navigation is affected.

So instead of explicitly setting textScaleFactor = 1 for the close button, I'm thinking about wrapping a MediaQuery with textScaleFactor = 1 around the nav bar, or doing it in CupertinoPageScaffold so developers can override the MediaQuery for the nav bar by wrapping a different MediaQuery around their nav bar. Thoughts?

@LongCatIsLooong I was so focused on fixing the Cancel button that didn’t thought on preventing the app bar scaling by default, which completely makes sense.

I agree, looks like a reasonable solution. Leaving the possibility to override the text scale for users that want to implement that, but, by default, staying at 1.0 according to iOS HIG. 👍🏻

@miguelpruivo would you mind reviewing #38593?

@LongCatIsLooong done. Thank you for “fixing” it. 🙂

@miguelpruivo closing. Thanks for contributing!