Twiggle bit to exclude dev and beta from desktop and web#35221
Twiggle bit to exclude dev and beta from desktop and web#35221jonahwilliams merged 5 commits intoflutter:masterfrom
Conversation
| /// Whether we are currently on the master branch. | ||
| bool get isMaster { | ||
| final String branchName = getBranchName(); | ||
| return branchName != 'stable' && branchName != 'dev' && branchName != 'beta'; |
There was a problem hiding this comment.
How about
return !<String>['dev', 'beta', 'stable].contains(branchName);
| case TargetPlatform.windows_x64: | ||
| case TargetPlatform.linux_x64: | ||
| if (FlutterVersion.instance.isStable) { | ||
| if (!FlutterVersion.instance.isMaster) { |
There was a problem hiding this comment.
Will this trigger for people who have renamed their master branch (e.g. folks working on this feature)? I guess if it does we'll find out and can easily fix it.
There was a problem hiding this comment.
Also, another way to handle this would be to have a helper function isDesktopEnabled() and isWebEnabled() so that we can change this rule later w/o having to find all 10 spots again. :)
| /// Whether we are currently on the master branch. | ||
| bool get isMaster { | ||
| final String branchName = getBranchName(); | ||
| return !<String>['dev', 'beta', 'stable'].contains(branchName); |
There was a problem hiding this comment.
This feels like it will fail for people who are working on a git branch.
There was a problem hiding this comment.
Unless we also want to stop all flutter engineers from working it, we'll need to permit user branches somehow
Piinks
added
the
tool
Codecov Report
@@ Coverage Diff @@
## master #35221 +/- ##
=========================================
Coverage ? 52.48%
=========================================
Files ? 175
Lines ? 16513
Branches ? 0
=========================================
Hits ? 8667
Misses ? 7846
Partials ? 0
Continue to review full report at Codecov.
|
Cherry-pick the following PRs onto v1.7.8-hotfixes to prepare for release. flutter/engine#9581 flutter/engine#9464 #35221
Cherry-pick the following PRs onto v1.7.8-hotfixes to prepare for release. flutter/engine#9581 flutter/engine#9464 flutter#35221
5 participants
No description provided.