Merged
Conversation
``` 45b66b7 Revert " Roll src/third_party/dart b37aa3b036...1eb113ba27 (flutter#9559)" (flutter#9584) fc1d86b Revert "Avoid a full screen overlay within virtual displays (flutter#9343)" (flutter#9581) 140b2ae Roll src/third_party/dart b37aa3b036...1eb113ba27 (flutter#9559) 94bb7a7 Adds API for retaining intermediate engine layers (flutter#9461) 7d1508d Roll fuchsia/sdk/core/mac-amd64 from cFEtOUFvy2XYSKuSmCMDaMQV8_Y7GOif521L3x86J_4C to n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC (flutter#9579) 7a0bbf9 Fixed memory leak by way of accidental retain on implicit self (flutter#9329) ```
Contributor
|
This is running into the same problem that @a-siva is hitting in his Dart roll. |
Contributor
|
(and likely the same problem that's blocking the auto-roller) |
Contributor
Author
|
Oops, added one more commit (Siva's revert of the dart roll) |
goderbauer
added
the
c: contributor-productivity
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
``` 45b66b7 Revert " Roll src/third_party/dart b37aa3b036...1eb113ba27 (flutter#9559)" (flutter#9584) fc1d86b Revert "Avoid a full screen overlay within virtual displays (flutter#9343)" (flutter#9581) 140b2ae Roll src/third_party/dart b37aa3b036...1eb113ba27 (flutter#9559) 94bb7a7 Adds API for retaining intermediate engine layers (flutter#9461) 7d1508d Roll fuchsia/sdk/core/mac-amd64 from cFEtOUFvy2XYSKuSmCMDaMQV8_Y7GOif521L3x86J_4C to n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC (flutter#9579) 7a0bbf9 Fixed memory leak by way of accidental retain on implicit self (flutter#9329) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine haven't rolled for a while, creating a manual roll to include the minimal set of changes needed to revert the #35291 regression.
Fixes: #35291