Add PopupMenuTheme to enable theming color, shape, elevation, text style of Menu by lisa-liao · Pull Request #36088 · flutter/flutter

lisa-liao · 2019-07-12T19:08:36Z

Description

This change introduces a PopupMenuEntryTheme that allows you to theme the color, shape, elevation, and text style of a menu. This can be done at the theme level and at call time of showMenu. See the following image for an example:

A gist showing how to generate this menu is here.

Related Issues

Closes #36076

Tests

I added the following tests:

*Tests for the theme and modifying the color/shape/elevation/text style of a menu

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.
The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
No, this is not a breaking change.

googlebot · 2019-07-12T19:08:39Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

rami-a

Good stuff, just a handful of minor comments/questions.

rami-a · 2019-07-15T19:00:58Z

packages/flutter/test/material/popup_menu_theme_test.dart

+    shape: BeveledRectangleBorder(borderRadius: BorderRadius.circular(12)),
+    elevation: 12.0,
+    textStyle: const TextStyle(
+        color: Color(0xffffffff), textBaseline: TextBaseline.alphabetic),


Specifying the baseline doesn't seem necessary and can be omitted

textBaseline is null if left unspecified, and basic.dart requires that textBaseline be non-null.

rami-a · 2019-07-15T19:01:36Z

packages/flutter/test/material/popup_menu_theme_test.dart

+
+    final AnimatedDefaultTextStyle text =
+        tester.widget<AnimatedDefaultTextStyle>(
+      find


The formatting is a bit weird here, maybe put the find on the same line as descendant here and throughout this file?

rami-a · 2019-07-15T19:02:47Z

packages/flutter/test/material/popup_menu_theme_test.dart

+    final Material button = tester.widget<Material>(
+      find
+          .descendant(
+            of: find.byKey(popupButtonApp),


I don't think I quite follow how this gets the actual menu widget, could you explain?

The last actual piece of material under the popupButtonApp widget is the menu widget itself. So by finding the last descendent of popupButtonApp that is of type Material, this code gets the actual menu widget.

rami-a · 2019-07-15T19:03:08Z

packages/flutter/lib/src/material/theme_data.dart

    return _cache[key] = loader();
  }
-}
+}


You should undo this change

rami-a · 2019-07-15T19:03:50Z

packages/flutter/lib/src/material/popup_menu_theme.dart

+  @override
+  void debugFillProperties(DiagnosticPropertiesBuilder properties) {
+    super.debugFillProperties(properties);
+    properties.add(ColorProperty(


You don't have to stick to the 80 char limit so I'd keep everything on the same line so that this is more readable

rami-a · 2019-07-15T19:06:33Z

packages/flutter/lib/src/material/popup_menu_theme.dart

+    this.textStyle,
+  });
+
+  /// Default value for [_PopupMenuRoute.color].


Add an additional line for each property documentation explaining what will be used if this is null. Look at card_theme.dart for examples.

I think it might be better to describe the property itself. I'm unsure if routing developers to look at source code (since it's a private widget) is ideal. See the properties for ToggleButtonsThemeData for examples.

rami-a · 2019-07-15T19:07:17Z

packages/flutter/lib/src/material/popup_menu_theme.dart

+import 'package:flutter/foundation.dart';
+import 'package:flutter/rendering.dart';
+
+/// Defines default property values for [PopupMenuEntry]'s [Material].


It's not just for material since the text style is in here too, should be enough to just say `[PopupMenuEntry] widgets

rami-a · 2019-07-15T19:08:22Z

packages/flutter/lib/src/material/popup_menu.dart

      showMenu<T>(
        context: context,
-        elevation: widget.elevation,
+        elevation: widget.elevation ?? popupMenuEntryTheme.elevation ?? 8.0,


I see this logic (for elevation, shape, and color) repeated in 2 spots, does it have to be?

Done (The paths are essentially combined into 1 now!)

rami-a · 2019-07-15T19:09:30Z

packages/flutter/lib/src/material/popup_menu_theme.dart

+  });
+
+  /// Default value for [_PopupMenuRoute.color].
+  final Color surfaceContainerColor;


This is a bit of a mouthful, color would be enough (and consistent with other themes) I think

rami-a · 2019-07-15T19:10:47Z

packages/flutter/lib/src/material/popup_menu.dart


+  /// The text style of the entry.
+  ///
+  /// Defaults to [blackMountainView].


It looks like this doesn't actually default to blackMountainView. You can say something like:

If this is null, then popupMenuTheme.textStyle is used. If that is also null, then theme.textTheme.subhead is used.

rami-a

LGTM!

shihaohong

Some minor changes to the documentation and removing one line of duplicate logic

shihaohong · 2019-07-18T04:32:08Z

packages/flutter/lib/src/material/popup_menu.dart


+  /// If provided, the shape used for the menu.
+  ///
+  /// If this is null, then popupMenuTheme.shape is used.


Suggested change

/// If this is null, then popupMenuTheme.shape is used.

/// If this is null, then [PopupMenuThemeData.shape] is used.

shihaohong · 2019-07-18T04:32:26Z

packages/flutter/lib/src/material/popup_menu.dart

+  /// The text style of the entry.
+  ///
+  /// If this is null, then [popupMenuTheme.textStyle] is used.
+  /// If that is also null, then [theme.textTheme.subhead] is used.


Suggested change

/// If that is also null, then [theme.textTheme.subhead] is used.

/// If that is also null, then [ThemeData.textTheme.subhead] is used.

shihaohong · 2019-07-18T04:32:37Z

packages/flutter/lib/src/material/popup_menu.dart


+  /// The text style of the entry.
+  ///
+  /// If this is null, then [popupMenuTheme.textStyle] is used.


Suggested change

/// If this is null, then [popupMenuTheme.textStyle] is used.

/// If this is null, then [PopupMenuThemeData.textStyle] is used.

shihaohong · 2019-07-18T04:33:13Z

packages/flutter/lib/src/material/popup_menu.dart

+
+  /// If provided, the color used for the menu.
+  ///
+  /// If this is null, then popupMenuTheme.color is used.


Suggested change

/// If this is null, then popupMenuTheme.color is used.

/// If this is null, then [PopupMenuThemeData.color] is used.

Is there a default color for the menu if neither are specified?

If these are null, then Theme.of(context).cardColor is used. If that is also null, then [ThemeData.cardTheme.color] is used. If that is also null, then [ThemeData.cardColor] is used.

shihaohong · 2019-07-18T04:38:48Z

packages/flutter/lib/src/material/popup_menu_theme.dart

+/// [PopupMenuEntryThemeData.copyWith].
+///
+/// Typically a [PopupMenuEntryThemeData] is specified as part of the
+/// overall [Theme] with [ThemeData.popupMenuThemeData].


Suggested change

/// overall [Theme] with [ThemeData.popupMenuThemeData].

/// overall [Theme] with [ThemeData.popupMenuTheme].

shihaohong · 2019-07-18T04:39:49Z

packages/flutter/lib/src/material/popup_menu_theme.dart

+    return typedOther.elevation == elevation
+        && typedOther.color == color
+        && typedOther.shape == shape
+        && typedOther.elevation == elevation


remove this line, it's a duplicate check of L99

shihaohong · 2019-07-18T04:40:52Z

packages/flutter/lib/src/material/theme_data.dart

  final BottomSheetThemeData bottomSheetTheme;

+  /// A theme for customizing the color, shape, elevation, and text style of a
+  /// menu.


Suggested change

/// menu.

/// popup menus.

shihaohong · 2019-07-18T04:41:10Z

packages/flutter/lib/src/material/theme_data.dart

  /// A theme for customizing the color, elevation, and shape of a bottom sheet.
  final BottomSheetThemeData bottomSheetTheme;

+  /// A theme for customizing the color, shape, elevation, and text style of a


Suggested change

/// A theme for customizing the color, shape, elevation, and text style of a

/// A theme for customizing the color, shape, elevation, and text style of

googlebot · 2019-07-18T19:06:02Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

shihaohong

There's a small bug where the widgets do not check for the PopupMenuTheme inherited widget, it would probably be good to add a test for that to validate the right behavior. I also added some comments about docs and formatting.

shihaohong · 2019-07-18T18:29:26Z

packages/flutter/lib/src/material/popup_menu.dart

  @override
  final double height;

+  /// The text style of the entry.


Suggested change

/// The text style of the entry.

/// The text style of the popup menu entry.

We try to make the first sentence as clear as possible so developers can very quickly understand what the API is for, or be reminded if they forget.

shihaohong · 2019-07-18T18:33:54Z

packages/flutter/lib/src/material/popup_menu.dart

  Widget build(BuildContext context) {
    final ThemeData theme = Theme.of(context);
-    TextStyle style = theme.textTheme.subhead;
+    final PopupMenuThemeData popupMenuTheme = theme.popupMenuTheme;


Suggested change

final PopupMenuThemeData popupMenuTheme = theme.popupMenuTheme;

final PopupMenuThemeData popupMenuTheme = TooltipTheme.of(context);

We want to retrieve the PopupMenuTheme configuration data from the closest ancestor in the widget tree.

I would maybe also add a test to verify that when

ThemeData.popupTheme is defined, those properties are utilized.

When ThemeData.popupTheme is defined, but a PopupTheme is also defined as a closer ancestor to any popup menu, properties from PopupThemeData are used instead.

shihaohong · 2019-07-18T18:34:43Z

packages/flutter/lib/src/material/popup_menu.dart

  Widget build(BuildContext context) {
    final double unit = 1.0 / (route.items.length + 1.5); // 1.0 for the width and 0.5 for the last item's fade.
    final List<Widget> children = <Widget>[];
+    final PopupMenuThemeData popupMenuTheme = Theme.of(context).popupMenuTheme;


Suggested change

final PopupMenuThemeData popupMenuTheme = Theme.of(context).popupMenuTheme;

final PopupMenuThemeData popupMenuTheme = TooltipTheme.of(context);

Ditto over here

shihaohong · 2019-07-18T18:37:39Z

packages/flutter/lib/src/material/popup_menu.dart


+  /// The text style of the entry.
+  ///
+  /// If this is null, then [PopupMenuThemeData.textStyle] is used.


Suggested change

/// If this is null, then [PopupMenuThemeData.textStyle] is used.

/// If this property is null, then [PopupMenuThemeData.textStyle] is used.

Avoid using 'this' or 'that', since it can be ambiguous

shihaohong · 2019-07-18T18:39:00Z

packages/flutter/lib/src/material/popup_menu.dart

+  /// The text style of the entry.
+  ///
+  /// If this is null, then [PopupMenuThemeData.textStyle] is used.
+  /// If that is also null, then [ThemeData.textTheme.subhead] is used.


Suggested change

/// If that is also null, then [ThemeData.textTheme.subhead] is used.

/// If [PopupMenuThemeData.textStyle] is also null, then [ThemeData.textTheme.subhead] is used.

shihaohong · 2019-07-18T19:18:35Z

packages/flutter/test/material/popup_menu_theme_test.dart

+    expect(button.shape, null);
+    expect(button.elevation, 8.0);
+
+    final AnimatedDefaultTextStyle text =


Same comment about formatting

packages/flutter/test/material/popup_menu_theme_test.dart

shihaohong · 2019-07-18T19:19:22Z

packages/flutter/test/material/popup_menu_theme_test.dart

+    expect(button.shape, popupMenuTheme.shape);
+    expect(button.elevation, popupMenuTheme.elevation);
+
+    final AnimatedDefaultTextStyle text =


Formatting here

packages/flutter/test/material/popup_menu_theme_test.dart

shihaohong · 2019-07-18T19:20:02Z

packages/flutter/test/material/popup_menu_theme_test.dart

+    expect(button.shape, shape);
+    expect(button.elevation, elevation);
+
+    final AnimatedDefaultTextStyle text =


Formatting here

shihaohong · 2019-07-18T21:06:47Z

packages/flutter/lib/src/material/popup_menu_theme.dart

+// found in the LICENSE file.
+
+import 'package:flutter/foundation.dart';
+import 'package:flutter/material.dart';


I think the analyzer might be complaining about this line being a recursive import. Just import the particular files you need and not the entire material library

googlebot · 2019-07-23T17:15:01Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

rami-a · 2019-07-23T17:36:12Z

packages/flutter/lib/src/material/theme_data.dart

    CupertinoThemeData cupertinoOverrideTheme,
    SnackBarThemeData snackBarTheme,
    BottomSheetThemeData bottomSheetTheme,
+    PopupMenuTheme popupMenuTheme,


This should still be PopupMenuThemeData for the type

shihaohong

I have some comments about formatting and the API documentation. Also, the analyzer seems to be complaining about something

shihaohong · 2019-07-23T22:42:43Z

packages/flutter/lib/src/material/popup_menu.dart

    this.semanticLabel,
+    this.shape,
+    this.color,
+    this.popupMenuTheme,


I would move this up under theme, so that the list of parameters is more intuitively ordered

shihaohong · 2019-07-23T22:43:08Z

packages/flutter/lib/src/material/popup_menu.dart

    }

    Widget menu = _PopupMenu<T>(route: this, semanticLabel: semanticLabel);
+    if(popupMenuTheme != null)


Suggested change

if(popupMenuTheme != null)

if (popupMenuTheme != null)

shihaohong · 2019-07-23T22:45:43Z

packages/flutter/lib/src/material/popup_menu.dart

    barrierLabel: MaterialLocalizations.of(context).modalBarrierDismissLabel,
+    shape: shape,
+    color: color,
+    popupMenuTheme: PopupMenuTheme.of(context),


Same as prior comment, make this right under theme. In general, we try to order parameters if there is a logical way to do so

shihaohong · 2019-07-23T22:47:45Z

packages/flutter/lib/src/material/popup_menu.dart


+  /// If provided, the shape used for the menu.
+  ///
+  /// If this property is null, then [PopupMenuThemeData.shape] is used.


Describe what the shape would be if PopupMenuThemeData.shape was null as well.

shihaohong · 2019-07-23T22:48:03Z

packages/flutter/lib/src/material/popup_menu.dart

+
+  /// If provided, the color used for the menu.
+  ///
+  /// If this property is null, then [PopupMenuThemeData.color] is used.


Describe what the color would be if PopupMenuThemeData.color was null as well.

shihaohong · 2019-07-23T23:08:35Z

packages/flutter/test/material/popup_menu_theme_test.dart

+      ).last,
+    );
+    expect(button.color, Colors.pink);
+    expect(button.shape,


Make this one line, or fix formatting

shihaohong · 2019-07-23T23:09:27Z

packages/flutter/test/material/popup_menu_theme_test.dart

+  });
+}
+
+PopupMenuThemeData _popupMenuTheme() {


It might be better to put this at the top of the file. I believe most test files in the framework follow that convention

Done (I was looking at the Bottom Sheet Theme which seems to have this at the bottom of the test file?)

I see, it must be a preference thing. The files I've worked on had them at the top of the file. Sorry about that!

shihaohong · 2019-07-23T23:10:01Z

packages/flutter/test/material/popup_menu_theme_test.dart

+      home: Material(
+        child: Column(
+          children: <Widget>[
+            PopupMenuButton<void>(


Remove <void>

The analyzer says that we can't remove <void> because type annotations must be specified.

shihaohong · 2019-07-23T23:10:06Z

packages/flutter/test/material/popup_menu_theme_test.dart

+      home: Material(
+        child: Column(
+          children: <Widget>[
+            PopupMenuButton<void>(


Remove <void>

The analyzer says that we can't remove <void> because type annotations must be specified.

shihaohong · 2019-07-23T23:10:10Z

packages/flutter/test/material/popup_menu_theme_test.dart

+              shape: BeveledRectangleBorder(borderRadius: BorderRadius.circular(10)),
+              elevation: 6.0,
+              textStyle: const TextStyle(color: Color(0xfffff000), textBaseline: TextBaseline.alphabetic),
+              child: PopupMenuButton<void>(


Remove <void>

The analyzer says that we can't remove <void> because type annotations must be specified.

shihaohong

One tiny nit about the API doc, otherwise LGTM!

You might also have to merge your changes with master. Some of the presubmit tests are complaining that seem unrelated to your changes.

shihaohong · 2019-07-24T15:32:38Z

packages/flutter/lib/src/material/popup_menu.dart

+  ///
+  /// If this property is null, then [PopupMenuThemeData.color] is used.
+  /// If [PopupMenuThemeData.color] is also null, then
+  /// [Theme.of(context).cardColor] is used.


nit, since this wouldn't create the link you're expecting:

Suggested change

/// [Theme.of(context).cardColor] is used.

/// Theme.of(context).cardColor is used.

googlebot · 2019-07-24T22:34:43Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

shihaohong · 2019-07-24T22:34:50Z

I'm manually updating the CLA since the PR contributor is a Googler

HansMuller · 2019-07-25T19:24:08Z

packages/flutter/lib/src/material/popup_menu_theme.dart

+
+/// Defines the visual properties of [PopupMenuEntry] widgets.
+///
+/// Descendant widgets obtain the current [PopupMenuEntryThemeData] object


It looks like PopupMenuEntry* should be PopupMenu* in the next couple of paragraphs.

Also: apps and material widgets should use PopupMenuTheme.of(context) (which defaults Theme.of(context).popupMenuTheme)).

HansMuller · 2019-07-25T19:25:11Z

packages/flutter/lib/src/material/popup_menu_theme.dart

+/// See also:
+///
+///  * [ThemeData], which describes the overall theme information for the
+///    application.


I don't think these links are needed.

HansMuller · 2019-07-25T19:28:26Z

packages/flutter/lib/src/material/popup_menu_theme.dart

+
+import 'theme.dart';
+
+/// Defines the visual properties of [PopupMenuEntry] widgets.


I think it would be clearer to say ...properties of the routes used to display popup menus as well as [PopupMenuItem] and [PopupMenuDivider] widgets.

HansMuller · 2019-07-25T19:31:18Z

packages/flutter/lib/src/material/popup_menu_theme.dart

+  /// The properties for descendant popup menu widgets.
+  final PopupMenuThemeData data;
+
+  /// The closest instance of this class' [data] value that encloses the given


class' should be class's. English is strange.

HansMuller · 2019-07-25T19:34:48Z

packages/flutter/test/material/popup_menu_theme_test.dart

+    expect(button.shape, popupMenuTheme.shape);
+    expect(button.elevation, popupMenuTheme.elevation);
+
+    final AnimatedDefaultTextStyle text = tester.widget<AnimatedDefaultTextStyle>(


Maybe just use DefaultTextStyle here

HansMuller · 2019-07-25T19:36:24Z

packages/flutter/test/material/popup_menu_theme_test.dart

+      find.descendant(
+        of: find.byKey(popupButtonApp),
+        matching: find.byType(Material),
+      ).last,


It's not clear what the ".last" material widget is. Maybe add a comment (here and below).

googlebot · 2019-07-25T21:49:57Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

HansMuller

Nice debut!

googlebot · 2019-07-26T17:06:43Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

rami-a · 2019-07-26T17:07:03Z

Overriding CLA as @lisa-liao is a googler

…yle of Menu (flutter#36088) * [Menu] Create Menu theme * [Menu] Create Menu theme * [Menu] Formatting changes for Menu theme * [Menu] Fix spacing difference in theme_data.dart. * [Menu] Fix spacing difference in theme_data.dart. * Specifying types * Formatting changes * Address PR feedback * Formatting changes * Address PR feedback * Add inherited widget * Add inherited widget * Address PR feedback and add inherited widget. * Formatting changes. * Address PR feedback * Address PR feedback * Address PR feedback * Address PR feedback

Lisa Liao added 6 commits July 10, 2019 15:27

[Menu] Create Menu theme

0af6770

[Menu] Create Menu theme

4b8aa4e

[Menu] Formatting changes for Menu theme

ae9ffaa

Merge branch 'master' of github.com:flutter/flutter

0feabd6

[Menu] Fix spacing difference in theme_data.dart.

a09e06d

[Menu] Fix spacing difference in theme_data.dart.

47248f3

fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 12, 2019

googlebot added the cla: no label Jul 12, 2019

Lisa Liao added 2 commits July 15, 2019 07:23

Specifying types

1adc97e

Formatting changes

ab4a18e

rami-a reviewed Jul 15, 2019

View reviewed changes

Address PR feedback

ddadbe6

rami-a approved these changes Jul 15, 2019

View reviewed changes

Formatting changes

1de8831

shihaohong self-requested a review July 18, 2019 04:22

shihaohong reviewed Jul 18, 2019

View reviewed changes

lisa-liao changed the title ~~Add PopupMenuEntryTheme to enable theming color, shape, elevation, text style of Menu~~ Add PopupMenuTheme to enable theming color, shape, elevation, text style of Menu Jul 18, 2019

Lisa Liao and others added 4 commits July 18, 2019 06:47

Address PR feedback

1d77b0e

Add inherited widget

65f3a87

Add inherited widget

b8ea815

Merge branch 'master' of github.com:lisa-liao/flutter

12a8754

shihaohong added cla: yes and removed cla: no labels Jul 18, 2019

shihaohong reviewed Jul 18, 2019

View reviewed changes

Address PR feedback and add inherited widget.

1073cd1

googlebot added cla: no and removed cla: yes labels Jul 23, 2019

Formatting changes.

09a0d35

rami-a reviewed Jul 23, 2019

View reviewed changes

Address PR feedback

a45a797

shihaohong approved these changes Jul 23, 2019

View reviewed changes

shihaohong self-requested a review July 23, 2019 23:13

Address PR feedback

9fb4baa

shihaohong approved these changes Jul 24, 2019

View reviewed changes

shihaohong self-assigned this Jul 24, 2019

Lisa Liao added 2 commits July 24, 2019 09:58

Address PR feedback

6665be7

Merge branch 'master' of github.com:flutter/flutter

d01c80c

shihaohong added cla: yes and removed cla: no labels Jul 24, 2019

HansMuller reviewed Jul 25, 2019

View reviewed changes

Address PR feedback

00cd48f

googlebot added cla: no and removed cla: yes labels Jul 25, 2019

HansMuller approved these changes Jul 25, 2019

View reviewed changes

rami-a added cla: yes and removed cla: no labels Jul 26, 2019

rami-a merged commit 63992e4 into flutter:master Jul 26, 2019

HansMuller mentioned this pull request Jul 31, 2019

Update constructor APIs TooltipTheme, ToggleButtonsTheme, PopupMenuTheme #37338

Merged

github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021

	/// If this is null, then popupMenuTheme.shape is used.
	/// If this is null, then [PopupMenuThemeData.shape] is used.

	/// If that is also null, then [theme.textTheme.subhead] is used.
	/// If that is also null, then [ThemeData.textTheme.subhead] is used.

	/// overall [Theme] with [ThemeData.popupMenuThemeData].
	/// overall [Theme] with [ThemeData.popupMenuTheme].

	/// A theme for customizing the color, shape, elevation, and text style of a
	/// A theme for customizing the color, shape, elevation, and text style of

	/// The text style of the entry.
	/// The text style of the popup menu entry.

	final PopupMenuThemeData popupMenuTheme = theme.popupMenuTheme;
	final PopupMenuThemeData popupMenuTheme = TooltipTheme.of(context);

	/// If this is null, then [PopupMenuThemeData.textStyle] is used.
	/// If this property is null, then [PopupMenuThemeData.textStyle] is used.

	/// If that is also null, then [ThemeData.textTheme.subhead] is used.
	/// If [PopupMenuThemeData.textStyle] is also null, then [ThemeData.textTheme.subhead] is used.

	/// [Theme.of(context).cardColor] is used.
	/// Theme.of(context).cardColor is used.


		import 'theme.dart';

		/// Defines the visual properties of [PopupMenuEntry] widgets.

Conversation

lisa-liao commented Jul 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Tests

Checklist

Breaking Change

Uh oh!

googlebot commented Jul 12, 2019

Uh oh!

rami-a left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rami-a left a comment

Choose a reason for hiding this comment

Uh oh!

shihaohong left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lisa-liao commented Jul 12, 2019 •

edited

Loading