Skip to content

Add multi-line flag to semantics#36297

Merged
mdebbar merged 2 commits intoflutter:masterfrom
mdebbar:semantics_multiline
Jul 18, 2019
Merged

Add multi-line flag to semantics#36297
mdebbar merged 2 commits intoflutter:masterfrom
mdebbar:semantics_multiline

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jul 16, 2019

Description

This flag is currently only used in the web engine to decide whether to create an <input> or <textarea> element.

This PR depends on the engine PR: flutter/engine#9850

Related Issues

Fixes #34265

Tests

I added the following tests:

  • test/widgets/editable_text_test.dart: "EditableText sets multi-line flag in semantics"

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@mdebbar mdebbar requested review from jonahwilliams and yjbanov July 16, 2019 19:47
@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels. labels Jul 16, 2019
@mdebbar mdebbar mentioned this pull request Jul 16, 2019
Merged
@jonahwilliams
Copy link
Contributor

jonahwilliams commented Jul 16, 2019

You'll also need to update: https://github.com/flutter/flutter/blob/master/packages/flutter_test/lib/src/matchers.dart#L397

yjbanov
yjbanov reviewed Jul 16, 2019
View reviewed changes
packages/flutter/lib/src/rendering/proxy_box.dart Outdated
Copy link
Contributor

@yjbanov yjbanov Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is null allowed at all?

Copy link
Contributor Author

@mdebbar mdebbar Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as other text-related fields. Not all semantics nodes are about text editing.

packages/flutter/lib/src/semantics/semantics.dart Outdated
Copy link
Contributor

@yjbanov yjbanov Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: when you say "in combination with" do you mean that textField must also be set to true? If so, I'd spell it out.

packages/flutter/lib/src/semantics/semantics.dart Outdated
Copy link
Contributor

@yjbanov yjbanov Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment in proxy_box.dart implies that null is a valid value for this field. Let's document what null means vs others.

packages/flutter/test/widgets/editable_text_test.dart Outdated
Copy link
Contributor

@yjbanov yjbanov Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are flags matched? Does this make sure that isMultiline flag is off? It is a little surprising that only one flag is on. For example, I'd expect isEnabled to also be on.

Copy link
Contributor Author

@mdebbar mdebbar Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RenderEditable doesn't set the isEnabled flag.

@mdebbar mdebbar force-pushed the semantics_multiline branch from 50414ff to c004059 Compare July 16, 2019 20:28
@Piinks Piinks added the platform-web Web applications specifically label Jul 17, 2019
@mdebbar mdebbar mentioned this pull request Jul 17, 2019
Merged
@mdebbar mdebbar force-pushed the semantics_multiline branch from 5ae1720 to 886fbad Compare July 17, 2019 21:46
@mdebbar mdebbar requested a review from yjbanov July 17, 2019 22:57
yjbanov
yjbanov approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdebbar mdebbar merged commit 9c9b71a into flutter:master Jul 18, 2019
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@mdebbar @johnsonmh
Add multi-line flag to semantics (flutter#36297)
4b5240e
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov yjbanov approved these changes

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web][upstream] In semantics upstream isMultiline

6 participants

@mdebbar @jonahwilliams @yjbanov @googlebot @Piinks @fluttergithubbot