Swap the semantics of the two StreamBuilder constructors#36577
Closed
tvolkert wants to merge 1 commit intoflutter:masterfrom
tvolkert:follow-on-stream-builder
Closed
Swap the semantics of the two StreamBuilder constructors#36577tvolkert wants to merge 1 commit intoflutter:masterfrom tvolkert:follow-on-stream-builder
tvolkert wants to merge 1 commit intoflutter:masterfrom
tvolkert:follow-on-stream-builder
Conversation
Based on a survey of usage, it appears that the ratio is about 3:1 of callers that create `StreamBuilder` _without_ initial data to callers that create `StreamBuilder` _with_ initial data. Given this, the updated API will break fewer callers if we swap the semantics of the two constructors: **Before** ```dart StreamBuilder( @required T initialData, ... ) StreamBuilder.withoutInitialData( ... ) ``` **After** ```dart StreamBuilder( ... ) StreamBuilder.withInitialData( @required T initialData, ... ) ``` This also allows us to provide a softer transition period by deprecating the `initialData` argument to the default constructor. During this deprecation period, null values will be interpreted as "no initial data". #34545
9 tasks
Contributor
This was referenced Jul 19, 2019
Contributor
Author
|
Closing since I reverted the original change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on a survey of usage, it appears that the ratio is about
3:1 of callers that create
StreamBuilderwithout initialdata to callers that create
StreamBuilderwith initial data.Given this, the updated API will break fewer callers if we swap
the semantics of the two constructors:
Before
After
This also allows us to provide a softer transition period by
deprecating the
initialDataargument to the default constructor.During this deprecation period, null values will be interpreted as
"no initial data".
Related Issues
#34545
Tests
I updated the existing tests to reflect the switch.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change