Updating cirrus fingerprint script to include goldens version#36690
Merged
Piinks merged 4 commits intoflutter:masterfrom Jul 23, 2019
Merged
Updating cirrus fingerprint script to include goldens version#36690Piinks merged 4 commits intoflutter:masterfrom
Piinks merged 4 commits intoflutter:masterfrom
Conversation
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygine page and make sure this patch meets those guidelines before LGTMing. /cc @dnfield |
This was referenced Jul 22, 2019
dnfield
reviewed
Jul 22, 2019
| } | ||
|
|
||
| Future<void> _checkCanSync() async { | ||
| final bool isCirrus = (platform.environment['CIRRUS_CI'] ?? '').isNotEmpty; |
Contributor
There was a problem hiding this comment.
nit: I think we check this elsewhwer as just platform.environment.containsKey('CIRRUS_CI')
dnfield
reviewed
Jul 22, 2019
Piinks
added
framework
Piinks
changed the title
Contributor
Author
|
cc/ @LongCatIsLooong |
8 tasks
fkorotkov
suggested changes
Jul 22, 2019
| flutter_pkg_cache: | ||
| folder: bin/cache/pkg | ||
| fingerprint_script: echo $OS; cat bin/internal/engine.version | ||
| fingerprint_script: echo $OS; cat bin/internal/*.version |
Contributor
There was a problem hiding this comment.
I think you missed it for other platforms like Windows and macOS
Contributor
Author
There was a problem hiding this comment.
Ah good point. Goldens are currently only tested on Linux, but we should keep it consistent regardless. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Local golden file changes should not exist on Cirrus, but were introduced in the reverted PR #33688. This removes those local changes that are creating a sync error for the goldens repository on cirrus, and maintains a safe guard against further errant local changes, thereby preserving the testing environment.
The fingerprint script for cirrus has been updated to incorporate the goldens version when deciding to invalidate the cache or not.
Related Issues
This blocks #36087 and any further updates to the goldens repository.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?