Skip to content

Tests for flutter test [some_directory]#36866

Merged
DaveShuckerow merged 5 commits intoflutter:masterfrom
DaveShuckerow:test-directory
Aug 13, 2019
Merged

Tests for flutter test [some_directory]#36866
DaveShuckerow merged 5 commits intoflutter:masterfrom
DaveShuckerow:test-directory

Conversation

@DaveShuckerow
Copy link
Contributor

@DaveShuckerow DaveShuckerow commented Jul 24, 2019

Adding test coverage to be sure we can test a directory's contents instead of just its children.

@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 24, 2019
jonahwilliams
jonahwilliams approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 24, 2019 •
edited
Loading

Codecov Report

Merging #36866 into master will decrease coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36866      +/-   ##
==========================================
- Coverage    55.5%   54.97%   -0.54%     
==========================================
  Files         190      190              
  Lines       17597    17590       -7     
==========================================
- Hits         9768     9670      -98     
- Misses       7829     7920      +91
Flag Coverage Δ
#flutter_tool 54.97% <ø> (-0.54%) ⬇️
Impacted Files Coverage Δ
...ackages/flutter_tools/lib/src/commands/attach.dart 9.13% <0%> (-65.6%) ⬇️
packages/flutter_tools/lib/src/commands/clean.dart 14.28% <0%> (-62.99%) ⬇️
...ages/flutter_tools/lib/src/linux/linux_doctor.dart 75% <0%> (-15%) ⬇️
packages/flutter_tools/lib/src/device.dart 53.01% <0%> (-12.05%) ⬇️
...ckages/flutter_tools/lib/src/ios/code_signing.dart 89.39% <0%> (-7.58%) ⬇️
.../flutter_tools/lib/src/runner/flutter_command.dart 79.18% <0%> (-3.25%) ⬇️
...ages/flutter_tools/lib/src/base/user_messages.dart 48.07% <0%> (-1.93%) ⬇️
...ackages/flutter_tools/lib/src/resident_runner.dart 51.8% <0%> (-1.41%) ⬇️
packages/flutter_tools/lib/src/compile.dart 74.08% <0%> (-0.67%) ⬇️
packages/flutter_tools/lib/src/cache.dart 47.05% <0%> (-0.52%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de9b44...a216d36. Read the comment docs.

@jonahwilliams
Copy link
Contributor

jonahwilliams commented Jul 25, 2019

Please ignore the codecov bot. It is correct, but still a little strict.

@DaveShuckerow DaveShuckerow merged commit 9615eb9 into flutter:master Aug 13, 2019
@DaveShuckerow DaveShuckerow deleted the test-directory branch August 13, 2019 21:57
@tvolkert
Copy link
Contributor

tvolkert commented Aug 15, 2019

FYI: https://github.com/flutter/flutter/wiki/Tree-hygiene#squashing-commits

The commit message for this commit contains:

"""

  • Add a test for a directory instead of a single test.

  • Add test data to a child directory to test the command.

  • Add test data to a child directory to test the command.

  • Add test data to a child directory to test the command.

  • Correct test.
    """

@DaveShuckerow
Copy link
Contributor Author

DaveShuckerow commented Aug 15, 2019

Thanks Todd, I will keep this in mind going forward.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DaveShuckerow @jonahwilliams @tvolkert @googlebot @fluttergithubbot