Skip to content

do not strip symbols when building profile#37210

Merged
xster merged 1 commit intoflutter:masterfrom
xster:symbols
Jul 30, 2019
Merged

do not strip symbols when building profile#37210
xster merged 1 commit intoflutter:masterfrom
xster:symbols

Conversation

@xster
Copy link
Member

@xster xster commented Jul 30, 2019 •
edited
Loading

Description

Leave them in since people aren't shipping profile builds and they're useful for instrumentations

Related Issues

Closes #37065

Tests

I added the following tests:

Module build test

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@xster xster requested review from cbracken and goderbauer July 30, 2019 03:02
@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 30, 2019
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jul 30, 2019

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

/cc @dnfield

goderbauer
goderbauer approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xster xster merged commit dfad039 into flutter:master Jul 30, 2019
@xster xster deleted the symbols branch July 30, 2019 20:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@cbracken cbracken Awaiting requested review from cbracken

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

We shouldn't strip dSYM for App.framework on profile mode

4 participants

@xster @fluttergithubbot @goderbauer @googlebot