Remove multi-arch check in iOS builds#37407
Remove multi-arch check in iOS builds#37407liamappelbe merged 2 commits intoflutter:masterfrom liamappelbe:simarm_x64_3
Conversation
fluttergithubbot
added
the
tool
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. /cc @dnfield |
|
Surprised we didn't have any tests for how we used to call gen_snapshot for iOS. They're no longer necessary in any case :) |
|
This roll was made without waiting for the bots to generate assets. I am reverting it as ToT is broken. |
This reverts commit 5809219.
|
It looks like when this was merged, the engine binaries weren't done building on LUCI yet, and the pre-commit checks were correspondingly red. Please don't merge commits until the pre-commit checks are green. |
|
I think the nuance in submitting breaking changes that was missed was that the red on the engine presubmit has to be ignored (because it checks against ToT framework) but the framework presubmits must always be green. |
6 participants
Description
As of flutter/engine#10010, iOS builds targeting armv7 are built using a 64-bit version of gen_snapshot that can produce 32-bit arm code. So this multi-arch special case is no longer necessary (and actually breaks the build).
Related Issues
#22598
Tests
I built the flutter examples in this mode using Xcode 10 and verified that they work on an iPhone 4S.
Manual roll
git log b41c172..9fca3c7 --no-merges --oneline
flutter/engine@9fca3c744 Use simarm_x64 when targeting arm (flutter/engine#10010)
flutter/engine@bf9288597 [fuchsia] Add kernel_compiler target in build_fuchsia script (flutter/engine#10403)