Pin package:vm_service_client to 0.2.6+2#37444
Closed
jamesderlin wants to merge 2 commits intoflutter:masterfrom
Closed
Pin package:vm_service_client to 0.2.6+2#37444jamesderlin wants to merge 2 commits intoflutter:masterfrom
jamesderlin wants to merge 2 commits intoflutter:masterfrom
Conversation
package:vm_service_client as of 0.2.6+3 is marked as deprecated. To avoid future analysis warnings when upgrading packages, pin it to 0.2.6+2 until we can fully migrate to using package:vm_service instead.
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. /cc @dnfield |
fluttergithubbot
added
the
tool
Codecov Report
@@ Coverage Diff @@
## master #37444 +/- ##
==========================================
- Coverage 55.27% 54.95% -0.32%
==========================================
Files 193 193
Lines 18017 18018 +1
==========================================
- Hits 9958 9902 -56
- Misses 8059 8116 +57
Continue to review full report at Codecov.
|
kevmoo
approved these changes
Aug 2, 2019
| 'build_runner': '1.6.1', // TODO(jonahwilliams): allow newer versions | ||
| 'build_modules': '2.3.0' | ||
| 'build_modules': '2.3.0', | ||
| 'vm_service_client': '0.2.6+2', // Final version before being marked deprecated. |
Contributor
There was a problem hiding this comment.
Worth adding a comment that this should be replaced w/ vm_service
Contributor
Author
There was a problem hiding this comment.
Done. I've filed #37499 and added a TODO.
jamesderlin
force-pushed
the
pin-vm-service-client
branch
from
20e424c to
013db57
Compare
Contributor
Author
|
PR #34252 includes this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
package:vm_service_client as of 0.2.6+3 is marked as deprecated. To
avoid future analysis warnings when upgrading packages, pin it to
0.2.6+2 until we can fully migrate to using package:vm_service
instead.
Tests
None.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?