Cc @amirh @mklim

Hmm... I've seen a lot of tests complaining about " | Because flutter_gallery depends on connectivity >=0.4.2+1 which requires Flutter SDK version >=1.2.0 <2.0.0, version solving failed." Any idea what the error is about?

The errors you're seeing are unrelated to this PR - I'd rebase against ToT and push the rebased commit to kick off fresh tests.

@adazh can you post an update to the breaking change announcement (https://groups.google.com/d/msg/flutter-announce/sHAL2fBtJ1Y/mGjrKH3dEwAJ), since the original announcement didn't call out the failure case of needing to initialize the binding before calling runApp() in cases of plugin initialization (or the case of tests).

thx!

@adazh can you post an update to the breaking change announcement (https://groups.google.com/d/msg/flutter-announce/sHAL2fBtJ1Y/mGjrKH3dEwAJ), since the original announcement didn't call out the failure case of needing to initialize the binding before calling runApp() in cases of plugin initialization (or the case of tests).

thx!

Sure, will do. @tvolkert @amirh Is tomorrow morning a good time to land this change? What time do you suggest?

@adazh if you could sync with @darrenaustin to find out the places that broke in Google's repo when the first attempt tried to roll, and send forwards-compatible fixes first, that would be very helpful, so we can land this once it's ready to roll and don't back up the roll again.

@adazh
With this change I need to call WidgetsFlutterBinding.ensureInitialized() in the main if I want to call some code before call runApp like Firestore (For get some preferences), but this show a black screen before runApp is called , I want to keep the native launch screen like before this change (not show other widget), how can I do that?

@basketball-ico Can you file an issue for this that shows some example code? Please mention me on the issue.

I can reproduce this, see #39494.

I am seeing this issue on Flutter main and dev channels and adding WidgetFlutterBinding.ensureInitialized() at the start of Main() doesn't make any difference. I spent hours trying to debug it and gave up switched to stable channel to make it go away.

@vikramkapoor are you talking about #39494?

Thanks for following up. What I meant is that I got the following exception due to the breaking change.

If you're running an application and need to access the binary messenger before `runApp()` has been called (for example, during plugin initialization), then you need to explicitly call the `WidgetsFlutterBinding.ensureInitialized()` first.
If you're running a test, you can call the `TestWidgetsFlutterBinding.ensureInitialized()` as the first line in your test's `main()` method to initialize the binding.
#0      defaultBinaryMessenger.<anonymous closure> 
package:flutter/…/services/binary_messenger.dart:73
#1      defaultBinaryMessenger 
package:flutter/…/services/binary_messenger.dart:86
#2      EventChannel.binaryMessenger 
package:flutter/…/services/platform_channel.dart:484
#3      EventChannel.receiveBroadcastStream.<anonymous closure> 
package:flutter/…/services/platform_channel.dart:504
<asynchronous suspension>
#4      _runGuarded  (dart:async/stream_controller.dart:805:24)
#5      _BroadcastStreamController._subscribe  (dart:async/broadcast_stream_controller.dart:213:7)
#6      _ControllerStream._createSubscription  (dart:async/stream_controller.dart:818:19)
#7      _StreamImpl.listen  (dart:async/stream_impl.dart:472:9)
#8      FlutterIsolate._isolateInitialize 
package:flutter_isolate/flutter_isolate.dart:104
#9      _flutterIsolateEntryPoint 
package:flutter_isolate/flutter_isolate.dart:132
#10     _runMainZoned.<anonymous closure>.<anonymous closure>  (dart:ui/hooks.dart:229:25)
#11     _rootRun  (dart:async/zone.dart:1124:13)
#12     _CustomZone.run  (dart:async/zone.dart:1021:19)
#13     _runZoned  (dart:async/zone.dart:1516:10)
#14     runZoned  (dart:async/zone.dart:1500:12)
#15     _runMainZoned.<anonymous closure>  (dart:ui/hooks.dart:221:5)
#16     _startIsolate.<anonymous closure>  (dart:isolate-patch/isolate_patch.dart:305:19)
#17     _RawReceivePortImpl._handleMessage  (dart:isolate-patch/isolate_patch.dart:172:12)

while running the following code after runApp() had already been called

 Globals.receivePort = ReceivePort();
            print("Spawning isolate 1");
            FlutterIsolate.spawn(isolate1, Globals.receivePort.sendPort).then((
                data) =>
            Globals.isolate = data);
            broadcastReceivePort =  Globals.receivePort.asBroadcastStream();

I added WidgetFlutterBinding.ensureInitialized() at the start of Main() as well as in the Isolate entry function . But the exception didn't go away after I did that on master and dev channels. It went away after switching to Stable channel. This was on an IOS build.

From the stack trace, the error was thrown when binaryMessenger.setMessageHandler was called within EventChannel's receiveBroadcastStream method.

@vikramkapoor Could you check where EventChannel(s) are initialized/receiveBroadcastStream is called in your code? This error should probably go away if WidgetFlutterBinding.ensureInitialized() is called beforehand.

@adazh
RunApp is called as first thing in my main() before receiveBroadcastStream. I had tried putting WidgetFlutterBinding.ensureInitialized() as the first line in main() before RunApp and it was still happening. This only happens on iOS and not on Android with the same code. I will investigate more a little later today and get back to this thread.

@adazh I tried calling WidgetFlutterBinding.ensureInitialized() as first thing in Main but I still get this error on iOS.  receiveBroadcastStream  is called in my code much after runApp has been called. It works fine on Android on the master channel but I had to go to stable channel on iOS to avoid this exception. Is there anything else I should investigate?  Vikram On Tuesday, September 3, 2019, 10:04:40 AM PDT, adazh [email protected] wrote: From the stack trace, the error was thrown when binaryMessenger.setMessageHandler was called within EventChannel's receiveBroadcastStream method. @vikramkapoor Could you see where EventChannel(s) are initialized/receiveBroadcastStream is called in your code? This error should probably go away if WidgetFlutterBinding.ensureInitialized() is called beforehand. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

I'm not aware of possible differences in bindings between Android and iOS. + @dnfield to see if he has any insight.

@vikramkapoor could you please file a new issue with a minimal reproduction for this? Feel free to tag me in it.

@dnfield Sure. I am working on minimal repro to file an issue