Add smoke tests to test every commit on a Catalina host.#38567
Add smoke tests to test every commit on a Catalina host.#38567digiter merged 2 commits intoflutter:masterfrom digiter:catalina-smoke
Conversation
Related issue: #36290.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
added
the
c: contributor-productivity
| @@ -0,0 +1,16 @@ | |||
| // Copyright 2016 The Chromium Authors. All rights reserved. | |||
tvolkert
left a comment
tvolkert
left a comment
There was a problem hiding this comment.
LGTM. We'll probably also want a basic hot reload test as well as a build/startup test in profile mode.
dev/devicelab/manifest.yaml
Outdated
| flaky: true | ||
|
|
||
| smoke_catalina_start_up: | ||
| description: > |
There was a problem hiding this comment.
Should be marked as flaky
There was a problem hiding this comment.
Every new test/host should be marked as flaky for a duration of time to avoid infra setup issues from effectively closing the tree
There was a problem hiding this comment.
sgtm. Is that documented anywhere?
digiter
changed the title
| flaky: true | ||
| required_agent_capabilities: ["mac-catalina/ios"] | ||
|
|
||
| smoke_catalina_hot_mode_dev_cycle__benchmark: |
|
|
||
| smoke_catalina_hot_mode_dev_cycle__benchmark: | ||
| description: > | ||
| A some test that runs on macOS Catalina, which is a clone of the Dart VM hot patching performance benchmarking. |
There was a problem hiding this comment.
Oh, hmm.. will this automatically spawn a new benchmark series? That's ok, I guess.
|
This added new benchmarks, which now need to be baselined. |
7 participants
Description
After this PR, every commit will trigger smoke tests on a machine running macOS Catalina. So that we could get a signal of our Catalina support.
Related Issues
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?