Revert "Automatic focus highlight mode for FocusManager (#37825)"#38866
Merged
gspencergoog merged 1 commit intoflutter:masterfrom Aug 21, 2019
Merged
Revert "Automatic focus highlight mode for FocusManager (#37825)"#38866gspencergoog merged 1 commit intoflutter:masterfrom
gspencergoog merged 1 commit intoflutter:masterfrom
Conversation
This reverts commit a11d731 because of a regression in flutter_gallery_ios32__transition_perf and 90th_percentile_frame_build_time_millis. See issue flutter#38860.
fluttergithubbot
added
f: material design
tvolkert
approved these changes
Aug 20, 2019
Contributor
Author
|
Note that reverting this is likely to cause a 3-5% increase in hello_world size, and a 15% regression in velocity_tracker_bench_aot_frontend (Moto G4). |
liyuqian
approved these changes
Aug 21, 2019
Contributor
Author
|
I'm still trying to determine which is worse: the regression in |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a11d731 because of a regression in
flutter_gallery_ios32__transition_perf and 90th_percentile_frame_build_time_millis.
See issue #38860.