ToggleButtons test improvement#38898
Merged
shihaohong merged 5 commits intoflutter:masterfrom Sep 5, 2019
shihaohong:toggle-buttons-finder
Merged
ToggleButtons test improvement#38898shihaohong merged 5 commits intoflutter:masterfrom shihaohong:toggle-buttons-finder
shihaohong merged 5 commits intoflutter:masterfrom
shihaohong:toggle-buttons-finder
Conversation
shihaohong
added
framework
HansMuller
reviewed
Aug 22, 2019
Contributor
There was a problem hiding this comment.
Maybe just define a local function that returns a text style. Like:
TextStyle buttonTextStyle(String text) {
return tester.widget<DefaultTextStyle>(
find.descendant(
of: find.widgetWithText(RawMaterialButton, text),
matching: find.byType(DefaultTextStyle),
)
).style;
}
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This improves the ToggleButtons test files to have more precise finders looking for
DefaultTextStyleandIconTheme. Instead of using the first ancestor widget looking up the tree (there will be 2+ widgets), it looks for the single descendant widget of theRawMaterialButton.Related Issues
n/a
Tests
The modified lines improve existing tests
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?