Skip to content

Add smoke tests for Catalina/Android testing.#39300

Merged
digiter merged 1 commit intoflutter:masterfrom
digiter:catalina
Aug 27, 2019
Merged

Add smoke tests for Catalina/Android testing.#39300
digiter merged 1 commit intoflutter:masterfrom
digiter:catalina

Conversation

@digiter
Copy link
Contributor

@digiter digiter commented Aug 27, 2019

Description

This PR adds smoke tests for testing Catalina host + Android device.

Related Issues

#36290

Tests

I added the following tests:

  • smoke_catalina_hot_mode_dev_cycle__benchmark.dart
  • smoke_catalina_start_up.dart

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 27, 2019
@digiter digiter merged commit b38302b into flutter:master Aug 27, 2019
@digiter digiter deleted the catalina branch August 27, 2019 18:23
GaryQian added a commit that referenced this pull request Aug 27, 2019
digiter pushed a commit that referenced this pull request Aug 27, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants