Skip to content

Revert "Add smoke tests for Catalina/Android testing."#39347

Merged
digiter merged 1 commit intomasterfrom
revert-39300-catalina
Aug 27, 2019
Merged

Revert "Add smoke tests for Catalina/Android testing."#39347
digiter merged 1 commit intomasterfrom
revert-39300-catalina

Conversation

@digiter
Copy link
Contributor

@digiter digiter commented Aug 27, 2019

Reverts #39300

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 27, 2019
@digiter digiter requested a review from GaryQian August 27, 2019 19:25
Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should be just a few minor analyzer fixes to reland this!

@digiter digiter merged commit 2f58d08 into master Aug 27, 2019
@digiter digiter deleted the revert-39300-catalina branch August 27, 2019 19:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants