Reland "Relax arguments around local engine, build hello_world with bitcode"#39434
Merged
dnfield merged 2 commits intoflutter:masterfrom Aug 28, 2019
Merged
Reland "Relax arguments around local engine, build hello_world with bitcode"#39434dnfield merged 2 commits intoflutter:masterfrom
dnfield merged 2 commits intoflutter:masterfrom
Conversation
…h bitcode (flutter#39357)" (flutter#39431)" This reverts commit 393106f.
fluttergithubbot
added
d: examples
jmagman
reviewed
Aug 28, 2019
|
|
||
| RunCommand eval "$(echo "static const int Moo = 88;" | xcrun clang -x c \ | ||
| ${arch_flags} \ | ||
| -fembed-bitcode-marker \ |
Codecov Report
@@ Coverage Diff @@
## master #39434 +/- ##
==========================================
- Coverage 57.2% 57.17% -0.03%
==========================================
Files 195 195
Lines 18510 18496 -14
==========================================
- Hits 10588 10575 -13
+ Misses 7922 7921 -1
Continue to review full report at Codecov.
|
Contributor
Author
|
Going to land this while the tree is green - the windows related tests that are still pending have no relevance to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relands #39357
This failed on the devicelab because the binary stub we build for JIT based builds needs to have embedded bitcode as well. I'm always embedding a bitcode marker here, because it should always be safe to do so. Relevant change is in a2009ce
Fixes #15288 again