Measure iOS CPU/GPU percentage by liyuqian · Pull Request #39439 · flutter/flutter

liyuqian · 2019-08-28T21:24:11Z

For #33899

Test added:

simple_animation_perf_ios

Test modified:

backdrop_filter_perf_ios__timeline_summary

We'll add the CPU/GPU measurement to more iOS tests
once it's proven to be non-flaky.

digiter

Where will the result show up? As new graphs on the performance dashboard?

digiter · 2019-08-28T21:50:37Z

dev/devicelab/lib/framework/utils.dart

Why this cannot be part of flutter/flutter/dev/devicelab?

Yes, there will be two new graphs (one for CPU, one for GPU) per test. I didn't directly put them under flutter/flutter/dev/devicelab because (1) I'm not sure the implication of licenses (of using another MIT licensed project); (2) the code there might not be held to the same standard as flutter repo so I can do some quick and hacky jobs; (3) the tool might be useful outside of Flutter.

(1) is the major reason and I started a discussion in the general discord chat room. I'm happy to move my code to flutter repo if licenses aren't an issue.

dnfield

We should come up with a better home for the package.

dnfield · 2019-08-28T21:50:40Z

dev/devicelab/lib/framework/utils.dart

Can we upstream this to flutter/packages, and probably publish it on pub? Then we could do a pub global activate with a specific version. As written, it seems likely to possibly break if you push new changes - it's also in a repo that none of the rest of the team can work on.

Good idea. I'll definitely move the code there if license isn't a problem.

dnfield · 2019-08-28T22:20:23Z

dev/devicelab/lib/tasks/perf_tests.dart

nit: the param name feels strange to me, maybe just measureCpuAndGpuUsage?

measureCpuAndGpuUsage was my original name and then I realized a name conflict with measureCpuAndGpuUsage method...

goderbauer · 2019-08-30T20:03:23Z

dev/devicelab/manifest.yaml

Please add a comment why this was marked as flaky (e.g. because its new and unproven).

Removed flaky.

For flutter/flutter#39439 and flutter/flutter#33899

For flutter#33899 Test added: - simple_animation_perf_ios Test modified: - backdrop_filter_perf_ios__timeline_summary We'll add the CPU/GPU measurement to more iOS tests once it's proven to be non-flaky.

liyuqian · 2019-09-16T17:46:35Z

@dnfield @goderbauer @digiter : ready to review again.

dnfield

LGTM

Thanks for doing the work to move the package where it belongs - this is much cleaner now!

digiter

LGTM

This reverts commit af9f424.

@dnfield

This reverts commit af9f424. Reverts #39439 Reason: this passed the local device lab test on my Macbook but it failed in the actual device lab. Will investigate, fix, and reland. TBR: @dnfield @goderbauer @tvolkert @Hixie

This reverts commit 652be88. This fix is in flutter/packages#37

This reverts commit 406b449.

…41400)

For flutter#33899 Test added: - simple_animation_perf_ios Test modified: - backdrop_filter_perf_ios__timeline_summary We'll add the CPU/GPU measurement to more iOS tests once it's proven to be non-flaky.

@dnfield

This reverts commit af9f424. Reverts flutter#39439 Reason: this passed the local device lab test on my Macbook but it failed in the actual device lab. Will investigate, fix, and reland. TBR: @dnfield @goderbauer @tvolkert @Hixie

This reverts commit 652be88. This fix is in flutter/packages#37

…ter#41234)" (flutter#41400)

liyuqian requested review from digiter, dnfield and flar August 28, 2019 21:24

fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 28, 2019

googlebot added the cla: yes label Aug 28, 2019

liyuqian added the c: performance Relates to speed or footprint issues (see "perf:" labels) label Aug 28, 2019

liyuqian requested review from goderbauer and yjbanov August 28, 2019 21:25

digiter reviewed Aug 28, 2019

View reviewed changes

dnfield suggested changes Aug 28, 2019

View reviewed changes

liyuqian mentioned this pull request Aug 30, 2019

Add a new package: measure flutter/packages#31

Merged

goderbauer reviewed Aug 30, 2019

View reviewed changes

liyuqian added a commit to flutter/packages that referenced this pull request Sep 9, 2019

Add a new package: measure (#31)

db15561

For flutter/flutter#39439 and flutter/flutter#33899

liyuqian mentioned this pull request Sep 9, 2019

Simple animation costs high CPU/GPU/Power usages (~20%) on iPhone 6 #31865

Closed

liyuqian added 3 commits September 14, 2019 14:50

Measure iOS CPU/GPU percentage

d055e77

For flutter#33899 Test added: - simple_animation_perf_ios Test modified: - backdrop_filter_perf_ios__timeline_summary We'll add the CPU/GPU measurement to more iOS tests once it's proven to be non-flaky.

Add missing licenses

093603a

Let devicelab specify the device id

17ae6e1

liyuqian force-pushed the simple_cpu_gpu branch from 57774b0 to 82c6aa7 Compare September 14, 2019 22:19

Use pub to get and run the package

634d0dd

liyuqian force-pushed the simple_cpu_gpu branch from 82c6aa7 to 634d0dd Compare September 16, 2019 17:45

dnfield approved these changes Sep 16, 2019

View reviewed changes

digiter approved these changes Sep 16, 2019

View reviewed changes

liyuqian merged commit af9f424 into flutter:master Sep 16, 2019

liyuqian added a commit that referenced this pull request Sep 16, 2019

Revert "Measure iOS CPU/GPU percentage (#39439)"

3b106ed

This reverts commit af9f424.

liyuqian mentioned this pull request Sep 16, 2019

Revert "Measure iOS CPU/GPU percentage" #40624

Merged

liyuqian mentioned this pull request Sep 24, 2019

Track CPU/GPU/Energy usage in our performance benchmarks #33899

Closed

liyuqian added a commit to liyuqian/flutter that referenced this pull request Sep 24, 2019

Reland "Measure iOS CPU/GPU percentage (flutter#39439)"

7ea79ff

This reverts commit 652be88. This fix is in flutter/packages#37

liyuqian added a commit that referenced this pull request Sep 26, 2019

Reland "Measure iOS CPU/GPU percentage (#39439)" (#41234)

406b449

This reverts commit 652be88. This fix is in flutter/packages#37

jonahwilliams pushed a commit that referenced this pull request Sep 26, 2019

Revert "Reland "Measure iOS CPU/GPU percentage (#39439)" (#41234)"

aef299c

This reverts commit 406b449.

jonahwilliams pushed a commit that referenced this pull request Sep 26, 2019

Revert "Reland "Measure iOS CPU/GPU percentage (#39439)" (#41234)" (#…

f1e7fe8

…41400)

Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019

Reland "Measure iOS CPU/GPU percentage (flutter#39439)" (flutter#41234)

ed3f856

This reverts commit 652be88. This fix is in flutter/packages#37

Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019

Revert "Reland "Measure iOS CPU/GPU percentage (flutter#39439)" (flut…

6baecc3

…ter#41234)" (flutter#41400)

github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021

Conversation

liyuqian commented Aug 28, 2019

Uh oh!

digiter left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dnfield left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liyuqian commented Sep 16, 2019

Uh oh!

dnfield left a comment

Choose a reason for hiding this comment

Uh oh!

digiter left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants