Remove run in shell and add unit test for chrome launching#39462
Merged
jonahwilliams merged 2 commits intoflutter:masterfrom Aug 30, 2019
Merged
Remove run in shell and add unit test for chrome launching#39462jonahwilliams merged 2 commits intoflutter:masterfrom
jonahwilliams merged 2 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
Codecov Report
@@ Coverage Diff @@
## master #39462 +/- ##
==========================================
+ Coverage 56.79% 57.26% +0.47%
==========================================
Files 195 195
Lines 18506 18506
==========================================
+ Hits 10510 10597 +87
+ Misses 7996 7909 -87
Continue to review full report at Codecov.
|
yjbanov
reviewed
Aug 29, 2019
| Future<Chrome> launch(String url, { bool headless = false, bool skipCheck = false }) async { | ||
| final String chromeExecutable = findChromeExecutable(); | ||
| final Directory dataDir = fs.systemTempDirectory.createTempSync(); | ||
| final Directory dataDir = fs.directory('.dart_tool'); |
Contributor
There was a problem hiding this comment.
Should this be something more specific?
Contributor
Author
There was a problem hiding this comment.
Yeah, it fills up the folder with junk, will fix
yjbanov
approved these changes
Aug 29, 2019
Contributor
Author
|
Ignoring add2app-macos which was disabled for repeated failures. Will land once build goes green |
zanderso
reviewed
Sep 3, 2019
| await chrome.chromeConnection.getTabs(); | ||
| } catch (e) { | ||
| await chrome.close(); | ||
| print('here'); |
| })); | ||
| } | ||
|
|
||
| class MockProcessManager extends Mock implements ProcessManager {} |
Member
There was a problem hiding this comment.
The MockProcessManager defined in mocks.dart looks like it does what you want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes chrome launching on windows by removing runInShell. Places the user data directory under .dart_tool and removes code that deletes it on tear down.
Fixes #39213
Fixes #38537