Switch to the Win32 Windows embedding#39836
Merged
stuartmorgan-g merged 1 commit intoflutter:masterfrom Sep 5, 2019
Merged
Conversation
Pulls the Win32 embedding artifacts instead of the GLFW versions for Windows.
fluttergithubbot
added
the
tool
Contributor
Author
|
The FDE side still needs a bit of work, but I'd like to have this ready to go when it's done. |
stuartmorgan-g
added
a: desktop
Codecov Report
@@ Coverage Diff @@
## master #39836 +/- ##
==========================================
- Coverage 57.33% 56.79% -0.54%
==========================================
Files 194 194
Lines 18691 18691
==========================================
- Hits 10716 10616 -100
- Misses 7975 8075 +100
Continue to review full report at Codecov.
|
stuartmorgan-g
pushed a commit
to google/flutter-desktop-embedding
that referenced
this pull request
Sep 5, 2019
…engine (#493) Updates Windows example and testbed for flutter/flutter#39836 Also switches the projects to Unicode, since the new code uses more Win32 APIs, and we want to be using the modern versions of those APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pulls the Win32 embedding artifacts instead of the GLFW versions for
Windows.
Related Issues
Fixes #38590
Tests
I added the following tests: Updated existing tests
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?
This is a breaking change for Windows, but Windows is explicitly not stable at this point.