Remove dead accessors of _getUnusedChangesInLastReload.#39837
Merged
rmacnak-google merged 1 commit intoflutter:masterfrom Sep 12, 2019
rmacnak-google:_getUnusedChangesInLastReload
Merged
Remove dead accessors of _getUnusedChangesInLastReload.#39837rmacnak-google merged 1 commit intoflutter:masterfrom rmacnak-google:_getUnusedChangesInLastReload
rmacnak-google merged 1 commit intoflutter:masterfrom
rmacnak-google:_getUnusedChangesInLastReload
Conversation
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
added
the
tool
Codecov Report
@@ Coverage Diff @@
## master #39837 +/- ##
==========================================
- Coverage 57.33% 56.81% -0.53%
==========================================
Files 194 194
Lines 18691 18646 -45
==========================================
- Hits 10716 10593 -123
- Misses 7975 8053 +78
Continue to review full report at Codecov.
|
jonahwilliams
approved these changes
Sep 12, 2019
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
Please add a brief description in the PR comment for future archaeologists.
jonahwilliams
added
waiting for customer response
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
This was part of a disused tool to explain what did and did not run after reload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was part of a disused tool to explain what did and did not run after reload.