Make CupertinoDynamicColor.resolve return null when given a null color#39927
Merged
LongCatIsLooong merged 3 commits intoflutter:masterfrom Sep 6, 2019
Merged
Make CupertinoDynamicColor.resolve return null when given a null color#39927LongCatIsLooong merged 3 commits intoflutter:masterfrom
LongCatIsLooong merged 3 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
f: cupertino
9 tasks
HansMuller
approved these changes
Sep 5, 2019
| /// Resolves the given [Color] by calling [resolveFrom]. | ||
| /// | ||
| /// If the given color is already a concrete [Color], it will be returned as is. | ||
| /// If the given color is null, returns null for convenience. |
Contributor
There was a problem hiding this comment.
You don't really need to say "for convenience".
6 tasks
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For convenience.
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?