Ensure frame is scheduled when root widget is attached#40105
Merged
goderbauer merged 3 commits intoflutter:masterfrom Sep 10, 2019
Merged
Ensure frame is scheduled when root widget is attached#40105goderbauer merged 3 commits intoflutter:masterfrom
goderbauer merged 3 commits intoflutter:masterfrom
Conversation
Contributor
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After the change in #39535 we were only scheduling the first frame on accident as a side-effect of the warm-up frame (
SchedulerBinding. scheduleWarmUpFrameawaitsSchedulerBinding.endOfFrame, which implicitly schedules a frame). This PR makes scheduling the frame more explicit right after the root widget is attached (that's the first point in time where the framework can produce a meaningful frame).Thanks to @brandondiamond for figuring this out and bringing it to my attention.
Related Issues
#39494
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?