Add an ephemeral directory to Windows projects#40194
Merged
stuartmorgan-g merged 2 commits intoflutter:masterfrom Sep 11, 2019
Merged
Add an ephemeral directory to Windows projects#40194stuartmorgan-g merged 2 commits intoflutter:masterfrom
stuartmorgan-g merged 2 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
Codecov Report
@@ Coverage Diff @@
## master #40194 +/- ##
=========================================
+ Coverage 58.11% 58.72% +0.6%
=========================================
Files 192 192
Lines 18443 18444 +1
=========================================
+ Hits 10719 10831 +112
+ Misses 7724 7613 -111
Continue to review full report at Codecov.
|
stuartmorgan-g
added a commit
to google/flutter-desktop-embedding
that referenced
this pull request
Sep 11, 2019
Updates the Windows builds for the breaking change in flutter/flutter#40194 Note: plugins continue to hard-code the cache dir instead of using FLUTTER_EPHEMERAL_DIR since currently they share the generated properties file, but need a project-local copy of the cache. That whole structure needs to be reworked, so the fact that it's currently hard-coded isn't worth trying to fix right now (e.g., by making FLUTTER_EPHEMERAL_DIR relative).
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Moves files generated in windows/flutter/ as part of the build to an ephemeral/ subdirectory, matching the approach used on macOS (and in the future, Windows). Adds that directory to the generated properties file to minimize hard-coding of paths in the project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves files generated in windows/flutter/ as part of the build to an ephemeral/ subdirectory, matching the approach used on macOS (and in the future, Windows).
Adds that directory to the generated properties file to minimize hard-coding of paths in the project.
Tests
I added the following tests: None. Updated existing tests.
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?
This is a breaking change for Windows, which is explicitly not stable.