Skip to content

remove io and isolate from libraries#40259

Merged
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:test_build
Sep 11, 2019
Merged

remove io and isolate from libraries#40259
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:test_build

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Sep 11, 2019 •
edited
Loading

Description

Missed this after the revert/reland.

Fixes #34858 (comment)

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Sep 11, 2019

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 11, 2019
@codecov
Copy link

codecov bot commented Sep 11, 2019 •
edited
Loading

Codecov Report

Merging #40259 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40259      +/-   ##
==========================================
- Coverage   58.81%   58.68%   -0.14%     
==========================================
  Files         192      192              
  Lines       18533    18533              
==========================================
- Hits        10901    10876      -25     
- Misses       7632     7657      +25
Flag Coverage Δ
#flutter_tool 58.68% <ø> (-0.14%) ⬇️
Impacted Files Coverage Δ
...s/flutter_tools/lib/src/windows/visual_studio.dart 40.27% <0%> (-40.28%) ⬇️
packages/flutter_tools/lib/src/commands/drive.dart 35% <0%> (-40%) ⬇️
...lutter_tools/lib/src/android/android_workflow.dart 33.96% <0%> (-29.56%) ⬇️
packages/flutter_tools/lib/src/ios/mac.dart 43.45% <0%> (-8.95%) ⬇️
packages/flutter_tools/lib/src/base/os.dart 25% <0%> (-8.07%) ⬇️
...ages/flutter_tools/lib/src/base/user_messages.dart 47.27% <0%> (-3.64%) ⬇️
...ckages/flutter_tools/lib/src/reporting/events.dart 94.64% <0%> (-3.58%) ⬇️
...ges/flutter_tools/lib/src/application_package.dart 64.41% <0%> (-2.25%) ⬇️
packages/flutter_tools/lib/src/version.dart 88.99% <0%> (-1.44%) ⬇️
packages/flutter_tools/lib/src/base/build.dart 67.22% <0%> (-0.85%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6ae95c...8c3f29a. Read the comment docs.

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Sep 11, 2019

Build appears green locally, submitting

@jonahwilliams jonahwilliams merged commit 963c8a8 into flutter:master Sep 11, 2019
@jonahwilliams jonahwilliams deleted the test_build branch September 11, 2019 19:40
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@Inconnu08
Remove io and isolate from libraries for web sdk (flutter#40259)
90dc8a1
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes

@yjbanov yjbanov Awaiting requested review from yjbanov

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Web] Dartev compile Error http module

4 participants

@jonahwilliams @fluttergithubbot @zanderso @googlebot