Convert build mode to lowercase in tool_backend#40393
Merged
stuartmorgan-g merged 1 commit intoflutter:masterfrom Sep 13, 2019
Merged
Conversation
On macOS and iOS, the build mode is converted to lowercase in the Flutter-side script, allowing projects to pass configuration names directly. This adds the same behavior to the tool_backend.dart script currently used by Windows and Linux, so that Windows builds can do the same (since the default configuration names used by VS, as in Xcode, start with a capital letter).
fluttergithubbot
added
the
tool
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
Author
|
I know longer term Windows and Linux will migrate to |
jonahwilliams
approved these changes
Sep 12, 2019
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
Seems reasonable.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #40393 +/- ##
=========================================
+ Coverage 58.56% 58.67% +0.1%
=========================================
Files 192 192
Lines 18595 18627 +32
=========================================
+ Hits 10890 10929 +39
+ Misses 7705 7698 -7
Continue to review full report at Codecov.
|
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
On macOS and iOS, the build mode is converted to lowercase in the Flutter-side script, allowing projects to pass configuration names directly. This adds the same behavior to the tool_backend.dart script currently used by Windows and Linux, so that Windows builds can do the same (since the default configuration names used by VS, as in Xcode, start with a capital letter).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On macOS and iOS, the build mode is converted to lowercase in the
Flutter-side script, allowing projects to pass configuration names
directly. This adds the same behavior to the tool_backend.dart script
currently used by Windows and Linux, so that Windows builds can do the
same (since the default configuration names used by VS, as in Xcode,
start with a capital letter).
Related Issues
None
Tests
I added the following tests: None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?