Make FlutterPluginRegistrant a static framework so add-to-app can use static framework plugins#40401
Merged
jmagman merged 1 commit intoflutter:masterfrom Sep 13, 2019
Merged
Conversation
… plugins with static frameworks
jmagman
added
platform-ios
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Member
|
LGTM. I don't see any cons to this approach. |
Codecov Report
@@ Coverage Diff @@
## master #40401 +/- ##
==========================================
- Coverage 58.78% 57.83% -0.96%
==========================================
Files 192 192
Lines 18596 18597 +1
==========================================
- Hits 10932 10755 -177
- Misses 7664 7842 +178
Continue to review full report at Codecov.
|
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
… plugins with static frameworks (flutter#40401)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If host app Podfiles are using
use_frameworks!and plugins vended as static frameworks (google_maps_flutter, google_sign_in etc) then FlutterPluginRegistrant must also be a static framework. I don't see a non-hacky way to parse the plugins at the point the template is generated, so I think FlutterPluginRegistrant just has to always be a static framework.Related Issues
Fixes #31104.
Tests
I updated module_test_ios to
use_frameworks!with google_sign_in on top of the new Swift test in #40302 and confirmed it failed before this change and succeeded after. Don't have a running CI test for this yet.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change