Remove fluter tool usage of protobuf#40410
Merged
jonahwilliams merged 2 commits intoflutter:masterfrom Sep 13, 2019
Merged
Conversation
fluttergithubbot
added
c: contributor-productivity
Codecov Report
@@ Coverage Diff @@
## master #40410 +/- ##
==========================================
+ Coverage 59.59% 59.6% +0.01%
==========================================
Files 192 191 -1
Lines 18602 18572 -30
==========================================
- Hits 11086 11070 -16
+ Misses 7516 7502 -14
Continue to review full report at Codecov.
|
jonahwilliams
changed the title
zanderso
approved these changes
Sep 13, 2019
| yaml: 2.1.16 | ||
| flutter_goldens_client: | ||
| path: ../flutter_goldens_client | ||
| protobuf: 0.13.15 |
Member
There was a problem hiding this comment.
Does this also need to be removed from the BUILD.gn?
Contributor
Author
There was a problem hiding this comment.
We technically still depend on this transitively...I'm not sure. I'd rather leave it in to be safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It looks protobuf is going to have some upcoming breaking changes. I don't want to deal with these, so instead I'll just switch back to JSON.