Skip to content

Rename useProguard method, so Gradle doesn't get confused#40440

Merged
blasten merged 1 commit intoflutter:masterfrom
blasten:issue_40213
Sep 13, 2019
Merged

Rename useProguard method, so Gradle doesn't get confused#40440
blasten merged 1 commit intoflutter:masterfrom
blasten:issue_40213

Conversation

@blasten
Copy link

@blasten blasten commented Sep 13, 2019

Description

In Gradle 5.1.1, the static method useProguard has higher precedence over the useProguard called in line 163. This causes a signature clash.

Related Issues

Fixes #40213

Tests

This will be tested in #40181

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 13, 2019
@blasten blasten requested a review from dnfield September 13, 2019 16:57
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten merged commit f29524a into flutter:master Sep 13, 2019
@blasten blasten deleted the issue_40213 branch September 13, 2019 20:02
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No signature of method: static FlutterPlugin.useProguard() is applicable for argument types: (Boolean) values: [true]

4 participants