roll libimobiledevice artifacts to signed version#41411
Merged
christopherfujino merged 1 commit intoflutter:masterfrom Sep 27, 2019
Merged
Conversation
…to signed versions
christopherfujino
added
tool
tvolkert
approved these changes
Sep 27, 2019
christopherfujino
deleted the
roll-usb-dependencies-to-signed-versions
branch
Merged
tvolkert
added a commit
that referenced
this pull request
Sep 27, 2019
* [flutter_tools] Report iOS mDNS lookup failures to analytics (#41384) * [flutter_tools] Adds tests of mdns analytics events (#41410) * [flutter_tool] Add analytics events for ios-mdns fallback success/failure (#41482) * roll ideviceinstaller, libimobiledevice, libplist, openssl & usbmuxd to signed versions (#41411)
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
…to signed versions (flutter#41411)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These dependencies were never signed, and thus will not work on Catalina with Gatekeeper enabled. For each of these repos, I made documentation only changes to generate new revision hashes (therefore the code for these binaries should be the same), but then codesigned the builds.
Tests
I locally ran the Catalina smoke test with this version checked out, and it passed. None of our unit tests actually invoke these binaries, but they will be exercised in post-submit in the device lab.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?