Don't update last compiled time when compilation is rejected#41424
Merged
jonahwilliams merged 1 commit intoflutter:masterfrom Sep 27, 2019
Merged
Don't update last compiled time when compilation is rejected#41424jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams merged 1 commit intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
Codecov Report
@@ Coverage Diff @@
## master #41424 +/- ##
==========================================
- Coverage 60.12% 59.54% -0.58%
==========================================
Files 193 193
Lines 18832 18832
==========================================
- Hits 11323 11214 -109
- Misses 7509 7618 +109
Continue to review full report at Codecov.
|
zanderso
approved these changes
Sep 27, 2019
jonahwilliams
pushed a commit
that referenced
this pull request
Sep 27, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If we reject the compilation, keep the source files invalidated until they are updated. This keeps the error if the user repeatedly recompiles with an exception
Fixes #41399